Remove unnecessary spotbugs suppressions
Label conflicting PRs / main (push) Waiting to run Details

This commit is contained in:
Mark Waite 2025-10-02 11:59:40 -06:00
parent 52daf50e33
commit c895a034b3
3 changed files with 0 additions and 9 deletions

View File

@ -36,7 +36,6 @@
package hudson.util; package hudson.util;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.NoSuchElementException; import java.util.NoSuchElementException;
@ -140,9 +139,6 @@ public class QuotedStringTokenizer
/* ------------------------------------------------------------ */ /* ------------------------------------------------------------ */
@Override @Override
@SuppressFBWarnings(
value = {"SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH", "SF_SWITCH_FALLTHROUGH"},
justification = "TODO needs triage")
public boolean hasMoreTokens() public boolean hasMoreTokens()
{ {
// Already found a token // Already found a token

View File

@ -2470,7 +2470,6 @@ public class Functions {
* Advertises the minimum set of HTTP headers that assist programmatic * Advertises the minimum set of HTTP headers that assist programmatic
* discovery of Jenkins. * discovery of Jenkins.
*/ */
@SuppressFBWarnings(value = "UC_USELESS_VOID_METHOD", justification = "TODO needs triage")
public static void advertiseHeaders(HttpServletResponse rsp) { public static void advertiseHeaders(HttpServletResponse rsp) {
Jenkins j = Jenkins.getInstanceOrNull(); Jenkins j = Jenkins.getInstanceOrNull();
if (j != null) { if (j != null) {

View File

@ -17,7 +17,6 @@ Lesser General Public License for more details.
package hudson.util.jna; package hudson.util.jna;
import com.sun.jna.ptr.IntByReference; import com.sun.jna.ptr.IntByReference;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import java.util.Collection; import java.util.Collection;
import java.util.TreeMap; import java.util.TreeMap;
@ -90,7 +89,6 @@ public class RegistryKey implements AutoCloseable {
return convertBufferToInt(getValue(valueName)); return convertBufferToInt(getValue(valueName));
} }
@SuppressFBWarnings(value = "SF_SWITCH_FALLTHROUGH", justification = "TODO needs triage")
private byte[] getValue(String valueName) { private byte[] getValue(String valueName) {
IntByReference pType, lpcbData; IntByReference pType, lpcbData;
byte[] lpData = new byte[1]; byte[] lpData = new byte[1];
@ -151,7 +149,6 @@ public class RegistryKey implements AutoCloseable {
/** /**
* Does a specified value exist? * Does a specified value exist?
*/ */
@SuppressFBWarnings(value = "SF_SWITCH_FALLTHROUGH", justification = "TODO needs triage")
public boolean valueExists(String name) { public boolean valueExists(String name) {
IntByReference pType, lpcbData; IntByReference pType, lpcbData;
byte[] lpData = new byte[1]; byte[] lpData = new byte[1];
@ -226,7 +223,6 @@ public class RegistryKey implements AutoCloseable {
* *
* @return TreeMap with name and value pairs * @return TreeMap with name and value pairs
*/ */
@SuppressFBWarnings(value = "SF_SWITCH_FALLTHROUGH", justification = "TODO needs triage")
public TreeMap<String, Object> getValues() { public TreeMap<String, Object> getValues() {
int dwIndex, result; int dwIndex, result;
char[] lpValueName; char[] lpValueName;