root
/
jenkins
mirror of https://github.com/jenkinsci/jenkins.git
1
0
Fork 0
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Don't animate admin monitor popup on page load, properly remove interactable UI elements (#8954) 

* followup for #8941, don't animate on page load

PR #8941 caused a regression that the hiding animation was played on
page load.
This change ensures that the hiding animation is only applied when the
widget was visible before

* scale to 0
This commit is contained in:
Markus Winter 2024-02-13 16:48:17 +01:00 committed by GitHub
parent 19863eb487
commit e5fd9127b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/main/resources/jenkins/management/AdministrativeMonitorsDecorator/resources.css
View File

@ -50,8 +50,12 @@
box-shadow: var(--dropdown-box-shadow);
border-radius: 15px;
opacity: 0;
animation: hide-am-list 300ms ease-in 1 normal;
z-index: 0;
transform: scale(0);
}
.am-container.am-hidden div.am-list {
animation: hide-am-list 300ms ease-in 1 normal;
}
.am-container.visible div.am-list {

4
core/src/main/resources/jenkins/management/AdministrativeMonitorsDecorator/resources.js
View File

@ -38,6 +38,7 @@
var popupContent = responseText;
amList.innerHTML = popupContent;
amMonitorRoot.classList.add("visible");
amMonitorRoot.classList.remove("am-hidden");
document.addEventListener("click", onClose);
document.addEventListener("keydown", onEscClose);
@ -50,6 +51,9 @@
}
function close() {
if (amMonitorRoot.classList.contains("visible")) {
amMonitorRoot.classList.add("am-hidden");
}
amMonitorRoot.classList.remove("visible");
document.removeEventListener("click", onClose);
document.removeEventListener("keydown", onEscClose);