Commit Graph

125 Commits

Author SHA1 Message Date
kohsuke 787d843d3d perform path normalization to get rid of "." and ".." in the path.
Without it, FilePath.getParent() and File.getParent() doesn't work correctly.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27956 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-26 00:30:15 +00:00
kohsuke 2676adca52 class initialization of Hudson is much more work than that of Util, so pushing these small utilities out to Util to reduce the overhead of remoting.
Plus it helps to keep Hudson.java smaller

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27448 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-13 01:30:56 +00:00
kohsuke bc66945943 allow InterruptedException to be forwarded
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26482 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-27 02:31:39 +00:00
kohsuke 61a1858dae exposing FileVisitor and DirScanner so that the calling app can fine tune the archiving process.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26226 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-21 23:25:14 +00:00
kohsuke 29cdfb670d [FIXED HUDSON-5271] in 1.342. Automatic tool installation wasn't honoring proxy setting.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25811 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-14 15:36:13 +00:00
kohsuke b6fbebe9ea [FIXED HUDSON-5272] improved error diagnostics in 1.342.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25810 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-14 15:23:49 +00:00
mindless 230333df15 fix javadoc typos
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25764 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-13 18:13:20 +00:00
kohsuke 47e06ffccb improved error message
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24899 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-24 02:43:02 +00:00
kohsuke 912e6ba8fe since FilePath.isUnix() isn't a complete guess, we need another safety check here.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24898 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-24 02:42:00 +00:00
kohsuke d69a5351f6 enhancing IO convenience code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24281 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-01 14:37:57 +00:00
mindless a96c6e02f8 [FIXED HUDSON-4894] match windows absolute path like C:/path as requested by torbent.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23889 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 16:14:51 +00:00
kohsuke 63e48ae865 improved the diagnosability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23882 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 01:49:03 +00:00
mindless e143c96f5c [FIXED HUDSON-4894] update DRIVE_PATTERN so a path like C:\ is recognized as absolute
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23832 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 23:38:20 +00:00
kohsuke d06333d8d3 create a directory if it doesn't exist.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23464 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-04 17:57:34 +00:00
kohsuke 0449001bd4 added a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23290 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-28 21:03:36 +00:00
kohsuke fe086df945 Automated tool downloads are made more robust by using HTTP download retries.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23122 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-24 00:15:29 +00:00
mindless f9a0284025 Add permission check in FilePath.validateFileMask,
and add note in javadoc for check already done in validateRelativePath.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22026 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-22 23:18:27 +00:00
kohsuke 97af019ca7 Merged revisions 21782-21783 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r21782 | kohsuke | 2009-09-17 10:22:50 -0700 (Thu, 17 Sep 2009) | 1 line
  
  [FIXED HUDSON-4039] Several classes need to be marked as serializable.
........
  r21783 | kohsuke | 2009-09-17 10:29:06 -0700 (Thu, 17 Sep 2009) | 1 line
  
  added a regression test for HUDSON-4039
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21797 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:31:48 +00:00
mindless db93c57e03 Add @Override annotations, one copyright header and some tab->ws
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21655 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:10:57 +00:00
jglick 2d8713a57c [HUDSON-4244] Making FilePath.delete throw IOException upon failure rather than return false.
Making Util.deleteFile public since it is useful.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@20816 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-17 23:17:53 +00:00
kohsuke c04e63d9f0 Merged revisions 19592-19593,19651,19669,19671-19672,19709,19712-19715,19728-19729,19825-19828,19859-19861,19863-19865,19869,19874-19875,19889,19896,19908-19909,19979,19982,20106,20115,20141-20144,20184,20196,20207-20208,20215-20216,20222,20286,20293 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/concurrent-build

........
  r19592 | kohsuke | 2009-07-10 14:02:22 -0700 (Fri, 10 Jul 2009) | 1 line
  
  introduced getWorkspace() and getModuleRoot() on AbstractBuild.
........
  r19593 | kohsuke | 2009-07-10 15:06:08 -0700 (Fri, 10 Jul 2009) | 1 line
  
  introduced a flag to control the behavior, so that we can expose the feature much later after we merge the branch into the trunk.
........
  r19651 | kohsuke | 2009-07-13 08:48:31 -0700 (Mon, 13 Jul 2009) | 1 line
  
  modified to work with multiple concurrent builds
........
  r19669 | kohsuke | 2009-07-13 14:25:58 -0700 (Mon, 13 Jul 2009) | 1 line
  
  updating TODOs
........
  r19671 | kohsuke | 2009-07-13 16:50:42 -0700 (Mon, 13 Jul 2009) | 1 line
  
  committing my changes before I push this up to the Run class.
........
  r19672 | kohsuke | 2009-07-13 17:14:41 -0700 (Mon, 13 Jul 2009) | 1 line
  
  pushed the change up to the Run class, which simplifies things a bit, and avoids a race condition in the final "notifyAll" when the build is completed.
........
  r19709 | kohsuke | 2009-07-14 17:56:24 -0700 (Tue, 14 Jul 2009) | 1 line
  
  added checkpoint methods to the base type of where it's commonly used, to simplify invocations.
........
  r19712 | kohsuke | 2009-07-14 18:16:50 -0700 (Tue, 14 Jul 2009) | 1 line
  
  revisited the CheckPoint abstraction. I think this is more OO now
........
  r19713 | kohsuke | 2009-07-14 18:17:18 -0700 (Tue, 14 Jul 2009) | 1 line
  
  doc fix
........
  r19714 | kohsuke | 2009-07-14 18:23:32 -0700 (Tue, 14 Jul 2009) | 1 line
  
  replaced AbstractProject.getWorkspace() by AbstractBuild.getWorkspace(). The easy ones are done, but the harder ones remain.
........
  r19715 | kohsuke | 2009-07-14 18:32:56 -0700 (Tue, 14 Jul 2009) | 1 line
  
  more getWorkspace() changes
........
  r19728 | kohsuke | 2009-07-15 11:17:25 -0700 (Wed, 15 Jul 2009) | 1 line
  
  removed more getWorkspace() usage by getSomeWorkspace()
........
  r19729 | kohsuke | 2009-07-15 11:17:43 -0700 (Wed, 15 Jul 2009) | 1 line
  
  this is done
........
  r19825 | kohsuke | 2009-07-17 15:35:21 -0700 (Fri, 17 Jul 2009) | 4 lines
  
  - refactored SCM triggering code to avoid queueing up too many threads.
  - workspace locking only happens if the SCM declares that the polling requires a workspace.
  
  TODO: given the face of concurrent builds, a single workspace lock won't work.
........
  r19826 | kohsuke | 2009-07-17 16:21:15 -0700 (Fri, 17 Jul 2009) | 5 lines
  
  implemented the handling of polling/build mutual exclusion when polling requires a workspace.
  
  The SCMs that require a workspace for polling, such as CVS, do so by comparing the state of the workspace
  vs that of the remote. So it needs to use the workspace of the last build. Polling needs to wait for this workspace
  if it's currently in use by a build, so a wait/notify scheme was needed, and hence WorkspaceList.
........
  r19827 | kohsuke | 2009-07-17 16:32:54 -0700 (Fri, 17 Jul 2009) | 1 line
  
  removed the workspace resource lock.
........
  r19828 | kohsuke | 2009-07-17 16:40:09 -0700 (Fri, 17 Jul 2009) | 1 line
  
  got rid of the lock. A build will always allocate an available workspace, so this is no longer necessary.
........
  r19859 | kohsuke | 2009-07-18 12:45:03 -0700 (Sat, 18 Jul 2009) | 2 lines
  
  Fixing a test failure. This might be signaling a depper abstraction problem, but let's see...
........
  r19860 | kohsuke | 2009-07-18 13:10:32 -0700 (Sat, 18 Jul 2009) | 1 line
  
  bug fix
........
  r19861 | kohsuke | 2009-07-18 13:12:18 -0700 (Sat, 18 Jul 2009) | 1 line
  
  typo
........
  r19863 | kohsuke | 2009-07-18 13:25:20 -0700 (Sat, 18 Jul 2009) | 1 line
  
  pass in common parameters for convenience.
........
  r19864 | kohsuke | 2009-07-18 13:36:34 -0700 (Sat, 18 Jul 2009) | 1 line
  
  doc fix
........
  r19865 | kohsuke | 2009-07-18 13:57:55 -0700 (Sat, 18 Jul 2009) | 1 line
  
  bug fix.
........
  r19869 | kohsuke | 2009-07-18 14:07:18 -0700 (Sat, 18 Jul 2009) | 2 lines
  
  This fixes the elusive NPE in com.gargoylesoftware.htmlunit.javascript.host.Event.<init>(Event.java:164)
........
  r19874 | kohsuke | 2009-07-18 14:44:39 -0700 (Sat, 18 Jul 2009) | 1 line
  
  forgot to update this.
........
  r19875 | kohsuke | 2009-07-18 14:44:48 -0700 (Sat, 18 Jul 2009) | 1 line
  
  forgot to update this.
........
  r19889 | kohsuke | 2009-07-18 16:12:04 -0700 (Sat, 18 Jul 2009) | 1 line
  
  fixed the license header.
........
  r19896 | kohsuke | 2009-07-18 16:16:44 -0700 (Sat, 18 Jul 2009) | 1 line
  
  adding a note.
........
  r19908 | kohsuke | 2009-07-18 17:13:03 -0700 (Sat, 18 Jul 2009) | 1 line
  
  fixed a bug. The parent build will likely run on a different node, so we can't just inherit its workspace.
........
  r19909 | kohsuke | 2009-07-18 17:16:54 -0700 (Sat, 18 Jul 2009) | 1 line
  
  reorgznied imports.
........
  r19979 | kohsuke | 2009-07-20 14:22:50 -0700 (Mon, 20 Jul 2009) | 1 line
  
  [HUDSON-4060] fixed a reported ClassCastException, but I don't think that's related to the hang problem.
........
  r19982 | kohsuke | 2009-07-20 14:51:11 -0700 (Mon, 20 Jul 2009) | 31 lines
  
  increasing the error margin in response to the flaky test that causes this error:
  
  unexpected build status; build log was: ------ Legacy code started this job.  No cause information is available Recording test results Test reports were found but none of them are new. Did tests run?  For example, /tmp/hudson3604989730528561398test/jobs/test0/workspace/junit.xml is 1 sec old  Finished: FAILURE  ------  expected:<UNSTABLE> but was:<FAILURE>
  
  Stacktrace
  
  junit.framework.AssertionFailedError: unexpected build status; build log was:
  ------
  Legacy code started this job.  No cause information is available
  Recording test results
  Test reports were found but none of them are new. Did tests run? 
  For example, /tmp/hudson3604989730528561398test/jobs/test0/workspace/junit.xml is 1 sec old
  Finished: FAILURE
  ------
   expected:<UNSTABLE> but was:<FAILURE>
  	at junit.framework.Assert.fail(Assert.java:47)
  	at junit.framework.Assert.failNotEquals(Assert.java:282)
  	at junit.framework.Assert.assertEquals(Assert.java:64)
  	at org.jvnet.hudson.test.HudsonTestCase.assertBuildStatus(HudsonTestCase.java:520)
  	at hudson.tasks.junit.CaseResultTest.testIssue20090516(CaseResultTest.java:74)
  
  Standard Output
  
  === Starting testIssue20090516
  
  Standard Error
  
  2009-07-20 07:20:23.430::INFO:  jetty-6.1.11
  2009-07-20 07:20:23.434::INFO:  NO JSP Support for /, did not find org.apache.jasper.servlet.JspServlet
  2009-07-20 07:20:23.436::INFO:  Started SocketConnector@0.0.0.0:45218
........
  r20106 | kohsuke | 2009-07-24 10:27:30 -0700 (Fri, 24 Jul 2009) | 1 line
  
  adding a few well-known check points to expose them to plugins.
........
  r20115 | kohsuke | 2009-07-24 14:42:58 -0700 (Fri, 24 Jul 2009) | 3 lines
  
  Added a mechanism to handle the compatibility with earlier plugins. Have plugins declare the synchronization service it expects Hudson to provide.
  
  This being binary compatible change allows Hudson to use existing plugins correctly, but it's source incompatibility allows us to advertize the new semantics to plugin developers, new or old.
........
  r20141 | kohsuke | 2009-07-24 19:03:07 -0700 (Fri, 24 Jul 2009) | 1 line
  
  better type safety
........
  r20142 | kohsuke | 2009-07-24 19:13:43 -0700 (Fri, 24 Jul 2009) | 1 line
  
  update the thread name to make the thread dump more understandable.
........
  r20143 | kohsuke | 2009-07-24 19:22:12 -0700 (Fri, 24 Jul 2009) | 1 line
  
  fixed a compilation problem.
........
  r20144 | kohsuke | 2009-07-24 19:30:22 -0700 (Fri, 24 Jul 2009) | 1 line
  
  fixed a test failure. Runner needs to be a stack.
........
  r20184 | kohsuke | 2009-07-27 10:51:20 -0700 (Mon, 27 Jul 2009) | 3 lines
  
  When remote JVM (in this case Maven) calls back to the proxy object, the executing thread needs to be able to behave as if it's the executor thread. So added the necessary abstractions for doing that.
  
  It might have been better to do this in the remoting, by using the blocking caller thread to serve requests. That would be harder, but it gets rid of this ugly ThreadLocal book keeping.
........
  r20196 | kohsuke | 2009-07-27 13:22:33 -0700 (Mon, 27 Jul 2009) | 1 line
  
  Fixed a test failure. The proxy interface needs to be public for the interceptor to be able to invoke it.
........
  r20207 | kohsuke | 2009-07-27 17:27:35 -0700 (Mon, 27 Jul 2009) | 1 line
  
  [HUDSON-4060] this class-level synchronization has a devastating effect as it effectively creates a single giant lock for the entire Hudson and can cause a dead lock.
........
  r20208 | kohsuke | 2009-07-27 17:28:58 -0700 (Mon, 27 Jul 2009) | 1 line
  
  improved the thread name.
........
  r20215 | kohsuke | 2009-07-28 10:58:15 -0700 (Tue, 28 Jul 2009) | 1 line
  
  added form databinding support for <f:optionalBlock>
........
  r20216 | kohsuke | 2009-07-28 11:00:35 -0700 (Tue, 28 Jul 2009) | 1 line
  
  concurrent build is now a switch activated for each project separately.
........
  r20222 | kohsuke | 2009-07-28 15:30:18 -0700 (Tue, 28 Jul 2009) | 3 lines
  
  bug fix in the rendering of the build history when you have some builds finished earlier than their earlier builds that are still in progress.
  
  This also fixes a race condition in a non concurrent build case, which can result in some build #s showing up more than once after AJAX update if the status of the build changes between the computation of 'nn' and that of the rendering.
........
  r20286 | kohsuke | 2009-07-29 11:05:00 -0700 (Wed, 29 Jul 2009) | 1 line
  
  still fixing more build list update issues. The original fix only kicked in for the list produced by AJAX, and didn't work for the initial list.
........
  r20293 | kohsuke | 2009-07-29 17:03:20 -0700 (Wed, 29 Jul 2009) | 1 line
  
  simplified a bit
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@20296 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-30 00:47:34 +00:00
kohsuke f4567eb822 [FIXED HUDSON-4039] Fixed a serilization problem.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19883 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-18 22:30:57 +00:00
kohsuke 9808c4c55f improved error diagnostics
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19708 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 00:41:37 +00:00
kohsuke 37aa48b0ee cherry picking from rev.19592.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19701 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-14 21:33:15 +00:00
sogabe f0ce8118bf I18N again
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19595 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 22:19:09 +00:00
sogabe 1943d19031 I18N & Japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19594 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 22:17:23 +00:00
kohsuke 46d1e006ae fixed the archiving code by de-composing it to a smaller orthogonal pieces
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19364 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 18:20:13 +00:00
kohsuke b7a52ff7ba rolling back my earlier change that seems to be breaking tests. will revisit this change later
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19332 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 23:44:08 +00:00
kohsuke 8ad45a5f10 introduced a visitor pattern to avoid code duplication
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19320 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 14:54:26 +00:00
kohsuke ee2ef56a0f added one more convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19095 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-20 03:13:29 +00:00
kohsuke 027a7e3e1b Fixed a bug in the non-ASCII character handling in remote bulk file copy.
(<a href="http://www.nabble.com/WG%3A-Error-when-saving-Artifacts-td24106649.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19075 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 23:19:33 +00:00
kohsuke 73b503bf67 C&P error
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18903 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-14 17:35:54 +00:00
kohsuke 00cf9f432f copy a file with permissions
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18899 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-14 16:04:36 +00:00
kohsuke 26971784d5 added a convenience method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18896 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-14 15:21:24 +00:00
kohsuke 3497535129 one more convenience method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18869 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-12 23:00:59 +00:00
kohsuke 716f50991b [FIXED HUDSON-3799] Fix for performance problem in FilePath.copyRecursiveTo() over the network.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18816 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-11 22:38:00 +00:00
kohsuke fa48bd2252 Didn't work if FileFilter is from a plugin: http://www.nabble.com/FilePath-list%28FileFilter%29-Probelm-with-slaves-td23856576.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18736 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-09 01:19:04 +00:00
jglick 277110898f Trying to install a JDK remotely on a Unix system threw a serialization exception.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18570 71c3de6d-444a-0410-be80-ed276b4c234a
2009-05-29 16:28:50 +00:00
kohsuke 46b540e5eb added more convenience methods
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18259 71c3de6d-444a-0410-be80-ed276b4c234a
2009-05-21 18:10:58 +00:00
kohsuke 5951d7a9b8 making this more defensive
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18221 71c3de6d-444a-0410-be80-ed276b4c234a
2009-05-20 02:04:47 +00:00
kohsuke 2a8a0bf7fa Merged revisions 17324-17325,17428,17430,17473-17475,17481-17482,17555-17563,17571,17593-17595,17619-17620,17637-17644,17656-17657,17663-17665,17667-17670,17730,17753,17755-17758,17763-17768,17770-17771,17901,17906,17911-17912,17958,17961-17962,17970-17977 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/tool-autoinstallation

........
  r17324 | jglick | 2009-04-20 18:24:32 -0700 (Mon, 20 Apr 2009) | 2 lines
  
  Defensive cloning and Javadoc corrections.
  (Though it seems no one is using the default impls of these methods yet anyway.)
........
  r17325 | jglick | 2009-04-20 18:29:06 -0700 (Mon, 20 Apr 2009) | 1 line
  
  Deprecation of delegate method is intentional.
........
  r17428 | jglick | 2009-04-23 08:07:14 -0700 (Thu, 23 Apr 2009) | 1 line
  
  Noting ToolLocationTranslator more prominently.
........
  r17430 | jglick | 2009-04-23 09:16:40 -0700 (Thu, 23 Apr 2009) | 1 line
  
  Unused imports.
........
  r17473 | jglick | 2009-04-23 19:21:11 -0700 (Thu, 23 Apr 2009) | 1 line
  
  Allow Plugin.configure to see the StaplerRequest, needed for some kinds of calls.
........
  r17474 | jglick | 2009-04-23 19:25:54 -0700 (Thu, 23 Apr 2009) | 3 lines
  
  Initial sketch of plugin to manage tool installations across slaves.
  (Should really be under ../plugins/ but that was not branched, so putting here for the moment.)
........
  r17475 | jglick | 2009-04-23 20:29:36 -0700 (Thu, 23 Apr 2009) | 1 line
  
  Typo in Javadoc.
........
  r17481 | jglick | 2009-04-23 22:46:26 -0700 (Thu, 23 Apr 2009) | 1 line
  
  Unzip of an unbuffered stream is painfully slow.
........
  r17482 | jglick | 2009-04-23 22:48:01 -0700 (Thu, 23 Apr 2009) | 1 line
  
  ZIP-based tool installer now functional.
........
  r17555 | jglick | 2009-04-27 17:50:38 -0700 (Mon, 27 Apr 2009) | 1 line
  
  Build against newest trunk.
........
  r17556 | jglick | 2009-04-27 18:38:28 -0700 (Mon, 27 Apr 2009) | 1 line
  
  Adding help.
........
  r17557 | jglick | 2009-04-27 18:57:46 -0700 (Mon, 27 Apr 2009) | 1 line
  
  Moving toolName & label config GUI into generic files.
........
  r17558 | jglick | 2009-04-27 19:37:30 -0700 (Mon, 27 Apr 2009) | 1 line
  
  Typo.
........
  r17559 | jglick | 2009-04-27 20:07:47 -0700 (Mon, 27 Apr 2009) | 1 line
  
  Second tool installer type based on a freeform command.
........
  r17560 | jglick | 2009-04-27 20:24:36 -0700 (Mon, 27 Apr 2009) | 1 line
  
  installIfNecessaryFrom will now just return false in case the target dir exists but the URL cannot be opened.
........
  r17561 | jglick | 2009-04-27 20:25:22 -0700 (Mon, 27 Apr 2009) | 2 lines
  
  chmod only if something was actually installed.
  Use a+x, not o+x.
........
  r17562 | jglick | 2009-04-27 20:26:46 -0700 (Mon, 27 Apr 2009) | 1 line
  
  Comment only.
........
  r17563 | jglick | 2009-04-27 20:41:12 -0700 (Mon, 27 Apr 2009) | 1 line
  
  I18N.
........
  r17571 | jglick | 2009-04-28 08:15:31 -0700 (Tue, 28 Apr 2009) | 2 lines
  
  Wiki link.
........
  r17593 | jglick | 2009-04-28 15:38:33 -0700 (Tue, 28 Apr 2009) | 1 line
  
  Turn off echo mode, it's just noise.
........
  r17594 | jglick | 2009-04-28 15:39:29 -0700 (Tue, 28 Apr 2009) | 2 lines
  
  Synchronizing access to installers for a given node/tool combo.
  Sending log messages to Hudson log in real time.
........
  r17595 | jglick | 2009-04-28 15:46:29 -0700 (Tue, 28 Apr 2009) | 1 line
  
  Copyrights.
........
  r17619 | jglick | 2009-04-29 06:25:23 -0700 (Wed, 29 Apr 2009) | 1 line
  
  Improved Javadoc.
........
  r17620 | jglick | 2009-04-29 06:51:11 -0700 (Wed, 29 Apr 2009) | 1 line
  
  Demonstraing how to use DLJ to mechanically install official JDK releases on supported operating systems.
........
  r17637 | kohsuke | 2009-04-30 16:15:24 -0700 (Thu, 30 Apr 2009) | 1 line
  
  fixed what appears to be a C&P mistake
........
  r17638 | kohsuke | 2009-04-30 16:16:21 -0700 (Thu, 30 Apr 2009) | 1 line
  
  show YUI logger if YUI debugging mode is set.
........
  r17639 | kohsuke | 2009-04-30 16:52:28 -0700 (Thu, 30 Apr 2009) | 7 lines
  
  Fixed a UI script problem when <hetero-list> nests inside <repeatable>.
  
  The cause of the problem was that the behavior for inner <hetero-list> kicks in first, altering HTML (by removing "prototypes"), before behavior for outer <repetable> kicks in and removes the master copy from DOM tree.
  
  So <repeatable> ends up computing a master copy after some elements are removed, and hence when we try to reinsert them later by clicking "Add", it'll get incorrect copy, and re-execution of the <hetero-list> behavior bombs out.
  
  I fixed this by skipping those HTML-altering behaviors if they show up in the part of DOM tree that's supposed to be snapshotted and removed.
........
  r17640 | kohsuke | 2009-04-30 16:57:58 -0700 (Thu, 30 Apr 2009) | 7 lines
  
  Added ToolProperty to ToolInstallation (which acts like NodeProperty to Node --- basically decorates the base object with additional properties.)
  
  The original motivation is to implement ToolInstaller this way, if Jesse is OK. But decorating tools seem to have some other interesting use, such as a plugin for configuring $M2_HOME/conf/settings.xml, or a plugin to insert unlimited cryptography extension to JDK, or a plugin to add a few more jars into $ANT_HOME/lib.
  
  For this to work, ToolInstallations that want properties needs to be modified to use a new constructor. For a starter, I modified the JDK class to do this.
  
  I also took the opportunity to modernize JDK/config.jelly.
........
  r17641 | kohsuke | 2009-04-30 17:02:04 -0700 (Thu, 30 Apr 2009) | 1 line
  
  this appears to be a left-over from early days when we didn't have a means to do form validation
........
  r17642 | kohsuke | 2009-04-30 17:02:35 -0700 (Thu, 30 Apr 2009) | 1 line
  
  we don't need no.such.JDK but we need name. rebranching
........
  r17643 | kohsuke | 2009-04-30 17:03:22 -0700 (Thu, 30 Apr 2009) | 1 line
  
  rebranched from Hudson's configure.properties
........
  r17644 | kohsuke | 2009-04-30 17:05:31 -0700 (Thu, 30 Apr 2009) | 1 line
  
  removed unnecessary translations
........
  r17656 | kohsuke | 2009-05-01 11:27:36 -0700 (Fri, 01 May 2009) | 1 line
  
  Less hack for improved type safety. Asking people to write more code is not necessarily bad as long as what they need to do is obvious to them.
........
  r17657 | kohsuke | 2009-05-01 12:07:20 -0700 (Fri, 01 May 2009) | 5 lines
  
  The toolautoinst part of the change that corresponds to rev.17640.
  
  ToolInstallers are now hooked under ToolInstallation through InstallSourceProperty as a ToolProperty.
  
  This allows the relevant UIs to be shown in one place. Still pending Jesse's feedback. Making it a single commit to simplify a revert if necessary
........
  r17663 | kohsuke | 2009-05-01 13:23:51 -0700 (Fri, 01 May 2009) | 1 line
  
  doc improvement
........
  r17664 | kohsuke | 2009-05-01 13:24:10 -0700 (Fri, 01 May 2009) | 1 line
  
  needs this to allow Stapler to databind hetero-list automatically
........
  r17665 | jglick | 2009-05-01 13:31:27 -0700 (Fri, 01 May 2009) | 1 line
  
  Warnings.
........
  r17667 | kohsuke | 2009-05-01 14:20:53 -0700 (Fri, 01 May 2009) | 1 line
  
  added a method to do chmod
........
  r17668 | kohsuke | 2009-05-01 14:30:35 -0700 (Fri, 01 May 2009) | 1 line
  
  prefer JDK6 version to avoid unnecessary JNA loading
........
  r17669 | kohsuke | 2009-05-01 14:33:09 -0700 (Fri, 01 May 2009) | 1 line
  
  no, I must have confused this.
........
  r17670 | kohsuke | 2009-05-01 15:57:11 -0700 (Fri, 01 May 2009) | 2 lines
  
  - Automated JDK installer and its test.
  - Minor update to the signature of ToolInstaller for supplying the expected default location.
........
  r17730 | kohsuke | 2009-05-04 11:27:34 -0700 (Mon, 04 May 2009) | 1 line
  
  avoid NPE as reported in HUDSON-3608
........
  r17753 | jglick | 2009-05-04 19:34:08 -0700 (Mon, 04 May 2009) | 2 lines
  
  Moved toolautoinst functionality into core.
........
  r17755 | jglick | 2009-05-04 20:28:34 -0700 (Mon, 04 May 2009) | 8 lines
  
  Added TaskListener parameter and IOException and InterruptedException to several methods:
  Run.getEnvironment
  NodeSpecific.forNode
  ToolLocationTranslator.getToolHome
  ToolLocationNodeProperty.getToolHome
  ToolInstallation.translateFor
  ProcessCache.Factory.getMavenInstallation
  ProcessCache.Factory.getJava
........
  r17756 | jglick | 2009-05-04 20:36:56 -0700 (Mon, 04 May 2009) | 1 line
  
  expectedLocation was never strictly necessary, and will soon no longer be used even by JDKInstaller.
........
  r17757 | jglick | 2009-05-04 20:40:41 -0700 (Mon, 04 May 2009) | 1 line
  
  Not sure yet what @since should be.
........
  r17758 | jglick | 2009-05-04 20:41:51 -0700 (Mon, 04 May 2009) | 1 line
  
  getDefaultInstallers method added. Not yet in use.
........
  r17763 | kohsuke | 2009-05-05 10:50:36 -0700 (Tue, 05 May 2009) | 1 line
  
  deprecated redundant getJavaHome method
........
  r17764 | kohsuke | 2009-05-05 12:10:45 -0700 (Tue, 05 May 2009) | 1 line
  
  added general-purpose property defaulting mechanism, and added default tool installer for JDK
........
  r17765 | jglick | 2009-05-05 12:35:56 -0700 (Tue, 05 May 2009) | 1 line
  
  capitalize("") -> ""
........
  r17766 | jglick | 2009-05-05 12:49:52 -0700 (Tue, 05 May 2009) | 1 line
  
  Missing @since.
........
  r17767 | jglick | 2009-05-05 13:01:41 -0700 (Tue, 05 May 2009) | 1 line
  
  Unchecked warning.
........
  r17768 | jglick | 2009-05-05 13:19:49 -0700 (Tue, 05 May 2009) | 2 lines
  
  Two unsuccessful attempts at form validation.
........
  r17770 | jglick | 2009-05-05 13:48:37 -0700 (Tue, 05 May 2009) | 1 line
  
  Better class names.
........
  r17771 | kohsuke | 2009-05-05 14:12:21 -0700 (Tue, 05 May 2009) | 5 lines
  
  brought the form validation check back. The trick is to use the 'value' parameter.
  
  In the end we'd expect this check to go away anyway, as we change input field to drop-down list, but in the mean time, this is why it didn't work.
  
  Maybe we probably need more static code checkers? Like FindBugs rules?
........
  r17901 | kohsuke | 2009-05-09 19:15:40 -0700 (Sat, 09 May 2009) | 1 line
  
  having two toolHome is odd.
........
  r17906 | kohsuke | 2009-05-10 11:09:13 -0700 (Sun, 10 May 2009) | 1 line
  
  adding the generalization of UpdateCenter, but for compatibility reasons, we are leaving UpdateCenter as-is.
........
  r17911 | kohsuke | 2009-05-10 17:02:53 -0700 (Sun, 10 May 2009) | 1 line
  
  integrated json-lib with a bit of bug fix
........
  r17912 | kohsuke | 2009-05-10 17:13:05 -0700 (Sun, 10 May 2009) | 1 line
  
  JDK list is now fetched from hudson.dev.java.net
........
  r17958 | kohsuke | 2009-05-11 13:44:25 -0700 (Mon, 11 May 2009) | 48 lines
  
  Handle AbortException better to avoid error like this:
  
  [INFO] ------------------------------------------------------------------------
  [ERROR] BUILD ERROR
  [INFO] ------------------------------------------------------------------------
  [INFO] Failed to delete directory: C:\files\hudson\workspace\hudson\hudson\main\remoting\target. Reason: Unable to delete file C:\files\hudson\workspace\hudson\hudson\main\remoting\target\remoting-1.304-SNAPSHOT.jar
  
  [INFO] ------------------------------------------------------------------------
  [INFO] For more information, run Maven with the -e switch
  [INFO] ------------------------------------------------------------------------
  [INFO] Total time: 31 seconds
  [INFO] Finished at: Sun May 10 18:15:33 PDT 2009
  [INFO] Final Memory: 25M/48M
  [INFO] ------------------------------------------------------------------------
  Recording fingerprints
  Archiving artifacts
  Recording test results
  ERROR: Failed to archive JUnit reports
  hudson.util.IOException2: remote file operation failed
  	at hudson.FilePath.act(FilePath.java:596)
  	at hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:82)
  	at hudson.model.AbstractBuild$AbstractRunner.performAllBuildStep(AbstractBuild.java:372)
  	at hudson.model.AbstractBuild$AbstractRunner.performAllBuildStep(AbstractBuild.java:360)
  	at hudson.model.Build$RunnerImpl.post2(Build.java:183)
  	at hudson.model.AbstractBuild$AbstractRunner.post(AbstractBuild.java:345)
  	at hudson.model.Run.run(Run.java:943)
  	at hudson.model.Build.run(Build.java:112)
  	at hudson.model.ResourceController.execute(ResourceController.java:93)
  	at hudson.model.Executor.run(Executor.java:119)
  Caused by: hudson.AbortException: Test reports were found but none of them are new. Did tests run? 
  For example, \files\hudson\workspace\hudson\hudson\main\core\target\surefire-reports\TEST-hudson.BulkChangeTest.xml is 2 days 23 hr old
  
  	at hudson.tasks.junit.TestResult.parse(TestResult.java:134)
  	at hudson.tasks.junit.TestResult.<init>(TestResult.java:95)
  	at hudson.tasks.junit.JUnitResultArchiver$1.invoke(JUnitResultArchiver.java:95)
  	at hudson.tasks.junit.JUnitResultArchiver$1.invoke(JUnitResultArchiver.java:82)
  	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:1583)
  	at hudson.remoting.UserRequest.perform(UserRequest.java:92)
  	at hudson.remoting.UserRequest.perform(UserRequest.java:46)
  	at hudson.remoting.Request$2.run(Request.java:236)
  	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
  	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
  	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
  	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
  	at java.lang.Thread.run(Thread.java:619)
........
  r17961 | kohsuke | 2009-05-11 15:16:39 -0700 (Mon, 11 May 2009) | 1 line
  
  adding Windows JDK silent installation
........
  r17962 | kohsuke | 2009-05-11 16:08:13 -0700 (Mon, 11 May 2009) | 1 line
  
  Fixing JDK offline installatino for Windows
........
  r17970 | kohsuke | 2009-05-11 19:37:59 -0700 (Mon, 11 May 2009) | 1 line
  
  Fixing a problem that prevents the usage of this tag in <repeatable> block, which reinserts the same fragment over and over. So statically assigning IDs won't work
........
  r17971 | kohsuke | 2009-05-11 22:17:09 -0700 (Mon, 11 May 2009) | 1 line
  
  continuing to remove static ID generation, which breaks the tag when used inside <repetable> tag.
........
  r17972 | kohsuke | 2009-05-11 22:19:11 -0700 (Mon, 11 May 2009) | 1 line
  
  I don't know when this started, but even in the hudson-dev:run mode, the versionis no longer '?', so we need a different way to force reload
........
  r17973 | kohsuke | 2009-05-11 22:26:34 -0700 (Mon, 11 May 2009) | 1 line
  
  adjusted the text a bit since multiple "add" and "delete"s were rather confusing
........
  r17974 | kohsuke | 2009-05-11 22:31:58 -0700 (Mon, 11 May 2009) | 1 line
  
  added help screen
........
  r17975 | kohsuke | 2009-05-11 22:41:39 -0700 (Mon, 11 May 2009) | 1 line
  
  form validation now works against the checkbox, too
........
  r17976 | kohsuke | 2009-05-11 22:43:00 -0700 (Mon, 11 May 2009) | 1 line
  
  with auto installation, we expect users to specify a directory that doesn't exist yet, so don't report it as an error
........
  r17977 | kohsuke | 2009-05-11 22:43:24 -0700 (Mon, 11 May 2009) | 1 line
  
  improving the text
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17985 71c3de6d-444a-0410-be80-ed276b4c234a
2009-05-12 13:59:10 +00:00
kohsuke ca8a5bde3f [FIXED HUDSON-3254] Use a bigger buffer size to improve remote I/O performance. Will be in 1.302.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17491 71c3de6d-444a-0410-be80-ed276b4c234a
2009-04-24 17:58:02 +00:00
kohsuke cc68d4a182 [HUDSON-2154] Adding more error diagnostic report in an attempt to find out a root cause. This change should let us see what's in the stream.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17320 71c3de6d-444a-0410-be80-ed276b4c234a
2009-04-21 00:13:54 +00:00
kohsuke dc086f6425 supported the zip file as well
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17064 71c3de6d-444a-0410-be80-ed276b4c234a
2009-04-11 21:17:15 +00:00
kohsuke 931c589d28 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17060 71c3de6d-444a-0410-be80-ed276b4c234a
2009-04-11 19:04:54 +00:00
kohsuke 2005e5e4f3 a few more convenience method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17054 71c3de6d-444a-0410-be80-ed276b4c234a
2009-04-11 15:40:38 +00:00
kohsuke 40c89bd263 Correctly detect the platform of the target node.
This is suspected to cause http://www.nabble.com/Re%3A-Launcher.isUnix%28%29-td22792399.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16724 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-30 20:45:35 +00:00
kohsuke f27e2b5c8a Using new form validation code
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16462 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-23 03:26:55 +00:00
kohsuke 3e647cae4f improved the error diagnosis. See http://www.nabble.com/No-javadoc-found-td22457649.html#a22457649
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16309 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-17 01:54:22 +00:00
swiest 2a2473d111 [FIXED HUDSON-3294] ZIP archives created by Hudson are now rendered properly in Windows' built-in "compressed folder" views.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16278 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-16 18:59:21 +00:00