Replacing Acegi Security with Spring Security
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
Overload the mechanisms for obtaining the jenkins-agent.jnlp (formerly slave-agent.jnlp) file for launching inbound TCP agents.
Serve the file at either of the two locations.
Change the UI (etc.) documentation to reference the correct term / file.
* JENKINS-61206 System read / Extended read for agents
* Update core/src/main/java/hudson/Functions.java
* Set permission to false explicitly
* Add message when no configured clouds
Otherwise there was a white page and it looked weird
* Hide password for Computer.EXTENDED_READ
* Add test
* Access controlled simplification
* Fix typoes / simplify code
* Simplify task.jelly
* Allow filtering system info extensions
* Show link that should be present
* Adjust MasterComputer access
* Adjust javadoc
* Adjust MasterComputer#configure
* Change links when read only access
* Use it instead of app
* Update core/src/main/resources/hudson/model/Computer/configure.jelly
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Code simplification
* Inline jelly text customisation
* Allow system read to see cloud move blurb
* Tooltip based on permission
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Show plugin release date in plugin manager
* Add at-since
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
* Make sorting work property
- Sort independently of sortable.js date parsing magic
- Hide categories when sorting by release date
* Show friendlier labels for the age of plugin releases
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
* New styles for breadcrumbs and warnings monitor
* Adds the svgxuse polyfill for svg sprites on IE 11
* Created new styles for the page header
- Used the material icons svg sprites to deliver the icons
- Icons are rendered using a <svg> tag
* Create new base styles file and undo changes to the layout-common and style css files
* Fixes and refactor for the new UI CSS code
* Make the new header color and logo section opt-in
- The new UI can be toggled with the -Dui.enableNewUi=true flag
* Rename and refactor the page-header css
- Rename the css class namespace from .main-header to .page-header
- Page header CSS moved into a modules folder and now included on the new-base-styles.css. This is done to avoid loading a separate file everytime.
- Extracted color variables to their own file
* Updated localization for header and admin monitor
- The pageHeader template receives localization strings as props
- Missing translation for the admin monitor on the it, bg and pl locales
* Update core/src/main/resources/lib/layout/layout.jelly
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
* Most measurements migrated to REMs
* Code cleanup and apply new-ui toggle to the html.jelly file
* Breadcrumb fixes
- Reverts breadcrumb link styling to use nested selectors instead of the .breadcrumbs__link class. The reason is that several plugins would break.
- Shifted margins so that breadcrumbs can be fullwidth in the absence of the auto refresh link
* Implemented some fixes from the feedback received
- Removed box shadow webkit prefix
- Fixed formatting on the breadcrumbs.css and layout-commons.less files
- Renamed the new UI toggle class from _new-ui_ to _ui-refresh_
- Renamed references to the _new ui_ to _v2_
* Created jelly helper to use svg icons
* Fix: restore proper icon for the user on the header
* Fixes for Edge, IE 11 and IE 10
* Improvements on the header and breadcrumbs
- Logo v2 changed and optimized using the svgo frontend https://jakearchibald.github.io/svgomg/
- Refactored the ammonitor insertion code
- Breadcrumbs are no longer capitalized
- Classic logo link no longer stretches past the images
- Fixed classic logo link on IE11
- Updated color of the footer
- Menu items background is also changed when hovering over the menu selector
- Removed copyright notice on top of some files
* Bumped JTH version with the SVG download fix
* Update test/pom.xml
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
* Added a function to check boolean system properties from jelly
* Fix header links and add svg styles for legacy layout
* Some bug fixing for the new header
- The ui-refresh changes were not properly being enabled with the boolean system property. Added explicit true check on the jelly templates.
- Added an explicit width for the ui-refresh logo because it would mess with the layout
* Update core/src/main/java/hudson/Functions.java
Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
* Do not check the system property on every page render
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* [JENKINS-59656] when stopping a Run via the executors widget, make sure it's the intended one
* [JENKINS-59656] added Executor.stopBuild(String) instead of .stop(String)
* revert change to deprecated doStop(StaplerRequest,StaplerResponse), useless now that it's doStopBuild(String) which takes a runExtId parameter
* javadoc: "@since TODO" rather than "@since 2.???"
* [JENKINS-59656] added test case
* jelly cleanup with h.urlEncode(String)
* make Functions.urlEncode(null) return empty String
* Executor.doStopBuild(runExtId): ignore runExtId if executable is not a Run
* Executor.doStopBuild(runExtId) doesn't have to be a public API
* set HttpOnly flag to prevent cookie read by a malicious script in browser
* Update core/src/main/java/hudson/Functions.java
Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com>
* Hide password form fields by default
* Trying to bypass enforced autocompletion by just having a test field at first
Something like onfocus didn't work, you'd tab through form elements
and unless you filled in the user name, changing the form field to
password would cause it to autocomplete.
It looks like, at least in Mac/Firefox, going from plain text to password
in the 'oninput' event handler works. The plain text is revealed neither
with typing nor pasting.
* Update core/src/main/resources/lib/form/password.jelly
Co-Authored-By: daniel-beck <daniel-beck@users.noreply.github.com>
* Use previously defined value
* Make new password form fields opt-out
* Add support for redacting form secrets in new password field
* Have a password value pre-set in Jelly
* Fix method
* Fix test by clicking on the button to change the password
* Forgot period separator between class and property name
Jesse Glick
Jeff Thompson
StefanSpieker
Daniel Beck
Félix Queiruga
Tim Jacomb
Daniel Beck
James Nord
Oleg Nenashev
Félix Queiruga
Thomas de Grenier de Latour
silent-snowman
Raihaan Shouhell
Egor18
Matt Sicker
Gustavo de Souza Bezerra
Josh Soref