Commit Graph

11668 Commits

Author SHA1 Message Date
Jesse Glick 12f5dec0ed junit 1.2-beta-3 2014-10-25 15:39:08 -07:00
Jesse Glick 2f8e2684af Merge pull request #1441 from mattmoor/upstream-javadoc
Change the javadoc of UpstreamCause to be more accurate...
2014-10-25 12:19:59 -04:00
Matt Moore 6ceb24cbd9 Change the javadoc of UpstreamCause to be more accurate (the upstream build need not be complete) 2014-10-25 08:54:11 -07:00
James Nord e135651539 [FIXED JENKINS-25280] Failed tests do not get displayed properly in the overview
there is no such mothod getFullDisplayName in a TestObject - only getDisplayName

Change-Id: Idd454be00a22ee3c93f661a3ee3ae322a25c271d
2014-10-23 17:03:26 +01:00
Jesse Glick 90292ed28a Null safety.
Observed in a test against 1.480:
… hudson.model.Executor run
SEVERE: Unexpected executor death
java.lang.NullPointerException
	at hudson.model.Computer.getNode(Computer.java:473)
	at hudson.slaves.SlaveComputer.getNode(SlaveComputer.java:177)
	at hudson.slaves.SlaveComputer.getRetentionStrategy(SlaveComputer.java:609)
	at hudson.slaves.SlaveComputer.taskCompleted(SlaveComputer.java:285)
	at hudson.model.queue.WorkUnitContext.synchronizeEnd(WorkUnitContext.java:140)
	at hudson.model.Executor.run(Executor.java:253)
2014-10-21 11:42:11 -04:00
Oleg Nenashev 6819a620c0 Noting #1411
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-19 23:47:35 +04:00
Oleg Nenashev e80fa118aa Merge pull request #1411 from synopsys-arc-oss/JENKINS-19017
[FIXED JENKINS-19017] - FileParameter - Handle non-null file parameters as different values
2014-10-19 23:28:14 +04:00
Oleg Nenashev cc06ae78e3 [JENKINS-19017] - Unit tests
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-18 22:03:28 +04:00
Stephen Connolly 4d987accef Clarify when to use SlaveComputer#setAcceptingTasks over RetentionStrategy#isAcceptingTasks(T) 2014-10-17 12:36:01 +01:00
Stephen Connolly 7acbba330c Typo 2014-10-17 12:21:12 +01:00
Stephen Connolly 10ac2b3ccd add @since tags 2014-10-17 12:20:07 +01:00
Stephen Connolly f07fb85352 Allow Node and RetentionStrategy to contribute to Computer#isAcceptingTasks 2014-10-17 09:38:32 +01:00
Kohsuke Kawaguchi 582128b9ac [FIXED JENKINS-25019]
A truly conforming servlet 3.0 container does not allow us to set "secure cookie" flag beyond ServletContextListener.onInitialized().
If we see that, don't scare the users.
2014-10-16 19:23:23 -07:00
Jesse Glick d2a0a6c2ae Merge pull request #1424 from synopsys-arc-oss/refactoring_User_class
Annotated hudson.model.User methods
2014-10-16 08:58:57 -04:00
Oleg Nenashev cafe5493a1 Merge pull request #1430 from garlandkr/master
Changed wording for command line message.
2014-10-16 15:23:33 +04:00
Oleg Nenashev 6e5520a7d5 Merge pull request #1416 from dominiquebrice/javadoc_update
Updating javadoc after struggling to add action to nodes
2014-10-16 15:21:40 +04:00
Stephen Connolly f423174d0b Additional safety as an addendum to 34b4bf52ad 2014-10-16 10:26:27 +01:00
Stephen Connolly 34b4bf52ad Do not fail certificate validation because some files in Jenkins Home are not actually certificates
- If there are any files in `$JENKINS_HOME/update-center-rootCAs` that are not ending in `.txt` and are
  not valid certificates, do not blow up the entire certificate checking (and hence the ability to see updates
  or tool installers) but rather ignore those files and warn the user that the file should not be there.
  The correct thing to do is only use as trusted certificates those certificates that parse.

- Also fix resource leak
2014-10-16 10:21:48 +01:00
Dominique 52941e3381 Updating javadoc after struggling to add action to nodes 2014-10-15 22:05:04 -04:00
Oleg Nenashev 04b8ef8a05 Annotated hudson.model.User methods.
The fix also includes comments in #1424 regarding Nonnull usage

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-16 02:00:47 +04:00
Kohsuke Kawaguchi c7e9882341 Restored backward compatibility.
Up to b5843f3, <t:ballColorTd> supported @iconSize="16x16" and so on that controls the color.
In the new scheme, it needs to be translated to iconSizeClass
2014-10-15 12:01:41 -07:00
Kohsuke Kawaguchi e8911ca33c Documenting what this setting controls 2014-10-15 12:01:41 -07:00
Kenneth Garland e168f4d4c9 Changed wording for command line message. 2014-10-15 14:26:05 -04:00
Daniel Beck d5d47edae4 Merge branch 'master' of https://github.com/jenkinsci/jenkins into JENKINS-3539
Conflicts:
	test/src/test/java/hudson/model/ParametersTest.java
2014-10-15 01:13:45 +02:00
Daniel Beck 190f0b6faf [FIXED JENKINS-3539] Prevent empty file creation if left empty 2014-10-15 00:33:49 +02:00
Kohsuke Kawaguchi d6f758af64 Accept "field" specified in the surrounding <f:entry> since this one expects <f:entry> 2014-10-14 11:31:50 -07:00
Jesse Glick 89db519e36 t:listScmBrowsers was not working inside f:dropdownDescriptorSelector.
It assumed it was used only inside config-scm.jelly, so assumed it could use ${scmd}
rather than the more standard ${descriptor}.
2014-10-14 09:40:37 -04:00
Jesse Glick 95c73c313f NPE in form validation when configured on a non-AbstractProject, like a workflow job. 2014-10-14 08:32:44 -04:00
Kohsuke Kawaguchi e219d19613 Added a method to read a file from the middle 2014-10-13 17:31:08 -07:00
Kohsuke Kawaguchi fad538f9ce read access to log file useful for plugins like support-core 2014-10-13 17:31:08 -07:00
Olivier Lamy 1cba6be58e Merge pull request #1334 from damienfinck/master
Improve French translation
2014-10-13 10:28:27 +11:00
Oleg Nenashev 55f15519ce Noting #1374
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-11 14:31:09 +04:00
Oleg Nenashev a7cc2a1b3a Merge pull request #1374 from synopsys-arc-oss/JENKINS-24340
[FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false
2014-10-11 14:20:59 +04:00
Oleg Nenashev c4df05b652 Merge pull request #1422 from daniel-beck/JENKINS-10197
[JENKINS-10197] Show keep log reason in tool tip
2014-10-11 13:56:44 +04:00
Harald Albers aeec1394f1 Merge pull request #1417 from bkmeneguello/portuguese-translation
Lots of translations and some typo fixes
2014-10-10 22:13:23 +02:00
Jesse Glick ef6c042447 Merge branch 'JENKINS-24763' of github.com:recampbell/jenkins 2014-10-10 15:28:58 -04:00
Oleg Nenashev d045618e0a Merge pull request #1421 from daniel-beck/JENKINS-24914
[FIXED JENKINS-24914] Don't block indefinitely every other month
2014-10-10 19:24:55 +04:00
Oleg Nenashev d158334f3b Merge pull request #1420 from daniel-beck/JENKINS-16184
[JENKINS-16184] Also escape greater-than character
2014-10-10 09:04:36 +04:00
Jesse Glick aac8c23972 [FIXED JENKINS-25081] Memory leak in BoundObjectTable when ProgressiveRendering is used. 2014-10-09 17:58:39 -04:00
Jesse Glick f463abbe53 [FIXED JENKINS-25074] Make sure to call Job.getBuildHealthReports just once per t:buildHealth render. 2014-10-09 15:24:00 -04:00
Oleg Nenashev a78f1d3246 [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false
This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check.
As an example, Subversion plugin behaves in such way (JENKINS-24341)

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-09 17:01:58 +04:00
Daniel Beck 0f0c2a7d00 [JENKINS-10197] Show keep log reason in tool tip 2014-10-09 00:54:31 +02:00
Daniel Beck adf8305f8b [FIXED JENKINS-24914] Don't block indefinitely every other month 2014-10-09 00:46:11 +02:00
Daniel Beck daacb02057 [JENKINS-16184] Also escape greater-than character 2014-10-09 00:38:22 +02:00
Jesse Glick c8b6f12784 Merge pull request #1414 from mattmoor/master
Convert AbstractProject to better utilize structure form submission.
2014-10-08 00:32:57 -04:00
Jesse Glick 0adf979c4a [FIXED JENKINS-10450] Use 404 status code for noWorkspace.jelly. 2014-10-07 23:33:30 -04:00
Jesse Glick bbb60e51ed Adding Option.toString; should make ListBoxModel.toString more useful for tests or debugging. 2014-10-07 14:06:49 -04:00
Bruno Kühnen Meneguello d6b4a69b81 Lots of translations and some typo fixes 2014-10-07 09:51:19 -03:00
Jesse Glick f8146742ed Better robustness when action loading fails.
For example, the following should not cause Run.onLoad itself to fail:
java.lang.NullPointerException
	at org.jenkinsci.plugins.workflow.steps.input.InputAction.onLoad(InputAction.java:29)
	at hudson.model.Run.onLoad(Run.java:342)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:332)
2014-10-06 12:54:24 -04:00
Jesse Glick 6825121f06 [JENKINS-21224] Defend against exceptions in listeners, for now just for ItemListener.
java.lang.RuntimeException: Unable to copy /…/jobs/…/config.xml
	at hudson.plugins.jobConfigHistory.FileHistoryDao.createNewHistoryEntryAndCopyConfig(FileHistoryDao.java:252)
	at hudson.plugins.jobConfigHistory.FileHistoryDao.createNewItem(FileHistoryDao.java:238)
	at hudson.plugins.jobConfigHistory.JobConfigHistoryJobListener.onCreated(JobConfigHistoryJobListener.java:31)
	at hudson.model.listeners.ItemListener.fireOnCreated(ItemListener.java:161)
	at jenkins.model.Jenkins.putItem(Jenkins.java:2483)
	at …
Caused by: java.io.FileNotFoundException: /…/jobs/…/config.xml (No such file or directory)
	at java.io.FileInputStream.open(Native Method)
	at java.io.FileInputStream.<init>(FileInputStream.java:120)
	at hudson.plugins.jobConfigHistory.FileHistoryDao.copyConfigFile(FileHistoryDao.java:178)
	at hudson.plugins.jobConfigHistory.FileHistoryDao.createNewHistoryEntryAndCopyConfig(FileHistoryDao.java:250)
	... 108 more
2014-10-06 10:18:16 -04:00