* remove YUI from ensureVisible
replace usage of YUI with plain javascript in the ensureVisible method
The current logic seems to have no effect, so it is changed in the
following
When the element is bigger then the current viewport height, scroll so
that the element is at the top.
If the elements is smaller than the viewport height and the bottom is
outside scoll so that the bottom is at the lower end of the viewport.
Otherwise no scrolling is needed the element is already completely
inside the viewport.
* apply prettier
* remove body.scrollTop
* experimental flag to run Jenkins without YUI
The YUI library is old and no longer maintained.
Add a user experimental flag to disable YUI. It's disabled by default.
When enabling all the YUI related js libraries and css classes are not
loaded.
Following PR are required to get Jenkins to not show any errors
eventually #7569
Some plugins that use YUI (not complete):
credentials
ldap
global-build-stats
build-monitor
categorized-view
Plugins that make use of makeButton (not complete)
credentials (fixed with https://github.com/jenkinsci/credentials-plugin/pull/533)
openid
acceptance-test-harness
* fix typo
Co-authored-by: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
* add license and restrict class
---------
Co-authored-by: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
* modernise build time trend page
- use jenkins-table
- add time since column
- make the link to the console an explicit icon (like for the agent
history)
- hide the agent column for pipeline jobs
* apply prettier
* missing let declaration
* fix tests
* change flex-direction with media
* apply prettier
* revert change to buildListTable
When the Jira issue is included in the changelog summary, it is included
in the generated changelog as the initial text of the changelog entry.
The same issue link is then included by the changelog generator at the end
of the changelog description. Remove the example that places the issue at
the start of the changelog text and explain that the issue link should be
elsewhere in the pull request so that the changelog generator can use it.
When the Jira issue is included in the changelog summary, the changelog
maintainers must remove it before the changelog is published. It is
better to not include the Jira issue in the changelog summary so that
changelog maintainers do not need to remove it.
Remind submitters that they should not delete the upgrade guidelines
section because the presence of the upgrade guidelines section is used
by the changelog generator as the terminator for the proposed changelog
entries.
* [JENKINS-73404] unit test
* roundtrip as Secrets
* [JENKINS-73404] add validation for SecretTextArea
reworked the jelly and simplified the javascript.
the textarea is now always present in the DOM, so no need to remove
inputs to add a textarea. Rather we just remove /hide the "hidden" attribute
from the elements we want to show/hide and give the textArea the
expected class and attributes for validation to occur
* remove unused data-prompt attribute
* Adapt getHiddenSecretValue to backend changes
* Adapt to Secrets being sent as "" rather than null
values for SecretTextArea are now always sent. Whilst this is a change
in behavior the only way once set to unset is to set the value to the
mpty string "" which would still produce a Secret
Additionally this matches the behaviour of f:password and f:textarea
Given both of the above this change in behaviour should not break any
production use cases.
* Remove trailing spaces
---------
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
[JENKINS-73543] make icon in buttons in tables resizable
With #9131 the jenkins-table__button was replaced at certain places with
jenkins-button. But this change caused two regressions:
- The icon size for large table was almost the same as that for medium
tables
- The icons wrapped in jenkins-button were not resizable
- with small table the buttons overflowed the table cell
This change restores the old icon size for large tables and adds
additional css rules for jenkins-button inside tables so they are
properly resized and the padding is correct
renovate[bot]
Basil Crow
dependabot[bot]
Jesse Glick
Daniel Beck
Markus Winter
Jenkins Release Bot
Mark Waite
James Nord
Vincent Latombe