Bug 58980 - JMS Subscriber will return successful as long as 1 message is received.

#resolve #111
Bugzilla Id: 58980

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1729146 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 3c61b54505

src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java

@@ -197,11 +197,14 @@ public class SubscriberSampler extends BaseJMSSampler implements Interruptible,
         if (read == 0) {
             result.setResponseCode("404"); // Not found
             result.setSuccessful(false);
-        } else { // TODO set different status if not enough messages found?
+        } else if (read < loop) { // Not enough messages found
+            result.setResponseCode("500"); // Server error
+            result.setSuccessful(false);
+        } else { 
             result.setResponseCodeOK();
             result.setSuccessful(true);
         }
-        result.setResponseMessage(read + " message(s) received successfully");
+        result.setResponseMessage(read + " message(s) received successfully of " + loop + " expected");
         result.setSamplerData(loop + " messages expected");
         result.setSampleCount(read);
         

xdocs/changes.xml

@@ -88,6 +88,7 @@ Summary
     <li>WebService(SOAP) Request and HTML Parameter Mask which were deprecated in 2.13 version, have now been removed following our <a href="./usermanual/best-practices.html#deprecation">deprecation strategy</a></li>
     <li>org.apache.jmeter.protocol.http.visualizers.RequestViewHTTP.getQueryMap signature has changed, if you use it ensure you update your code. See <bugzilla>58845</bugzilla></li>
     <li><code>__jexl</code> function has been deprecated and will be removed in next version. See <bugzilla>58903</bugzilla></li>
+    <li>JMS Subscriber will consider sample in error if number of received messages is not equals to expected number of messages. It previously considerer sample OK if only 1 message was received. See <bugzilla>58980</bugzilla></li> 
 </ul>
 
 <!-- =================== Improvements =================== -->
@@ -250,6 +251,7 @@ Summary
     <li><bug>58301</bug>Use typed methods such as setInt, setDouble, setDate ... for prepared statement #27</li>
     <li><bug>58851</bug>Add a dependency to hamcrest-core to allow JUnit tests with annotations to work</li>
     <li><bug>58947</bug>Connect metric is wrong when ConnectException occurs</li>
+    <li><bug>58980</bug>JMS Subscriber will return successful as long as 1 message is received. Contributed by Harrison Termotto (harrison dot termotto at stonybrook.edu)</li>
 </ul>
 
 <h3>Controllers</h3>
@@ -320,6 +322,7 @@ Summary
 <li>Vincent Herilier (vherilier at gmail.com)</li>
 <li>Florent Sabbe (f dot sabbe at ubik-ingenierie.com)</li>
 <li>Antonio Gomes Rodrigues (ra0077 at gmail.com)</li>
+<li>Harrison Termotto (harrison dot termotto at stonybrook.edu</li>
 </ul>
 
 <br/>