root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Move AdminCommandFailedException and AdminOperationException to tools module (#19614)
CI / build (push) Waiting to run Details 

AdminCommandFailedException and AdminOperationException are used only in
tools module, so move both into tools module.

Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai
 <chia7712@gmail.com>
This commit is contained in:
Jhen-Yung Hsu 2025-05-02 11:25:12 +08:00 committed by GitHub
parent 979f49f967
commit 014d0186cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
11 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server-common/src/main/java/org/apache/kafka/server/common/AdminCommandFailedException.java → tools/src/main/java/org/apache/kafka/tools/AdminCommandFailedException.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.common;
package org.apache.kafka.tools;
public class AdminCommandFailedException extends RuntimeException {
public AdminCommandFailedException(String message) {

2
server-common/src/main/java/org/apache/kafka/server/common/AdminOperationException.java → tools/src/main/java/org/apache/kafka/tools/AdminOperationException.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.common;
package org.apache.kafka.tools;
public class AdminOperationException extends RuntimeException {
public AdminOperationException(String message) {

2
tools/src/main/java/org/apache/kafka/tools/DeleteRecordsCommand.java
View File

@ -23,8 +23,6 @@ import org.apache.kafka.clients.admin.RecordsToDelete;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.utils.Exit;
import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import org.apache.kafka.server.util.CommandDefaultOptions;
import org.apache.kafka.server.util.CommandLineUtils;
import org.apache.kafka.server.util.Json;

2
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java
View File

@ -25,8 +25,6 @@ import org.apache.kafka.common.errors.ElectionNotNeededException;
import org.apache.kafka.common.errors.TimeoutException;
import org.apache.kafka.common.utils.Exit;
import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import org.apache.kafka.server.util.CommandDefaultOptions;
import org.apache.kafka.server.util.CommandLineUtils;
import org.apache.kafka.server.util.Json;

2
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java
View File

@ -46,8 +46,6 @@ import org.apache.kafka.common.errors.UnsupportedVersionException;
import org.apache.kafka.common.internals.Topic;
import org.apache.kafka.common.utils.Exit;
import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import org.apache.kafka.server.util.CommandDefaultOptions;
import org.apache.kafka.server.util.CommandLineUtils;
import org.apache.kafka.storage.internals.log.LogConfig;

4
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java
View File

@ -43,14 +43,14 @@ import org.apache.kafka.metadata.placement.ReplicaPlacer;
import org.apache.kafka.metadata.placement.StripedReplicaPlacer;
import org.apache.kafka.metadata.placement.TopicAssignment;
import org.apache.kafka.metadata.placement.UsableBroker;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import org.apache.kafka.server.config.QuotaConfig;
import org.apache.kafka.server.util.CommandLineUtils;
import org.apache.kafka.server.util.Json;
import org.apache.kafka.server.util.json.DecodeJson;
import org.apache.kafka.server.util.json.JsonObject;
import org.apache.kafka.server.util.json.JsonValue;
import org.apache.kafka.tools.AdminCommandFailedException;
import org.apache.kafka.tools.AdminOperationException;
import org.apache.kafka.tools.TerseException;
import org.apache.kafka.tools.ToolsUtils;

2
tools/src/test/java/org/apache/kafka/tools/DeleteRecordsCommandTest.java
View File

@ -26,8 +26,6 @@ import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.serialization.StringSerializer;
import org.apache.kafka.common.test.ClusterInstance;
import org.apache.kafka.common.test.api.ClusterTest;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import com.fasterxml.jackson.core.JsonProcessingException;

1
tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandErrorTest.java
View File

@ -17,7 +17,6 @@
package org.apache.kafka.tools;
import org.apache.kafka.common.errors.TimeoutException;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.junit.jupiter.api.Test;

1
tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java
View File

@ -28,7 +28,6 @@ import org.apache.kafka.common.test.ClusterInstance;
import org.apache.kafka.common.test.api.ClusterConfigProperty;
import org.apache.kafka.common.test.api.ClusterTest;
import org.apache.kafka.common.test.api.ClusterTestDefaults;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.mockito.ArgumentCaptor;
import org.mockito.MockedStatic;

2
tools/src/test/java/org/apache/kafka/tools/TopicCommandTest.java
View File

@ -56,8 +56,6 @@ import org.apache.kafka.common.test.api.ClusterTest;
import org.apache.kafka.common.test.api.Type;
import org.apache.kafka.common.utils.Exit;
import org.apache.kafka.metadata.LeaderAndIsr;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import org.apache.kafka.test.TestUtils;
import org.junit.jupiter.api.Assertions;

4
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java
View File

@ -29,9 +29,9 @@ import org.apache.kafka.common.errors.UnknownTopicOrPartitionException;
import org.apache.kafka.common.utils.Exit;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.metadata.placement.UsableBroker;
import org.apache.kafka.server.common.AdminCommandFailedException;
import org.apache.kafka.server.common.AdminOperationException;
import org.apache.kafka.server.config.QuotaConfig;
import org.apache.kafka.tools.AdminCommandFailedException;
import org.apache.kafka.tools.AdminOperationException;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;