root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

MINOR: Remove slf4j-log4j from kafka-streams compile dependencies 

As kafka-streams is intended to be used by applications that may or may not wish to use log4j, kafka-streams itself should not have a dependency on a concrete log framework.  This change adapts the dependencies to be API-only for compile, and framework-specific for the test runtime only.

I read through the [Contributing Code Guidelines](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes) and interpreted this as a trivial change that doesn't require a Jira ticket.  Please let me know if I've interpreted that wrongly.

This contribution is my original work and I license the work to the project under the project's open source license.

Author: Mathieu Fenniak <mathieu@encouragemarketing.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1639 from mfenniak/fix-slf4j-dependency-for-streams

(cherry picked from commit cfebfdfa5e)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
This commit is contained in:
Mathieu Fenniak 2016-07-19 15:45:12 -07:00 committed by Guozhang Wang
parent e9a1d69edd
commit 0bb1d3ae53
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
build.gradle
View File

@ -670,7 +670,7 @@ project(':streams') {
dependencies {
compile project(':clients')
compile project(':connect:json') // this dependency should be removed after we unify data API
compile libs.slf4jlog4j
compile libs.slf4jApi
compile libs.rocksDBJni
// this dependency should be removed after KIP-4
compile (libs.zkclient) {
@ -683,6 +683,8 @@ project(':streams') {
testCompile project(':core')
testCompile project(':core').sourceSets.test.output
testCompile libs.junit
testRuntime libs.slf4jlog4j
}
javadoc {