root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 5 Packages Projects Releases Wiki Activity

KAFKA-12615: Fix `Selector.clear()` javadoc typo (#10477) 

The second `clearCompletedSends()` reference should be `clearCompletedReceives()`.

Reviewers: Ismael Juma <ismael@juma.me.uk>

Co-authored-by: Zhao Haiyuan <zhaohaiyuan@mobike.com>
This commit is contained in:
zhaohaidao 2021-04-05 23:11:58 +08:00 committed by GitHub
parent 976e78e405
commit 136f584c05
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clients/src/main/java/org/apache/kafka/common/network/Selector.java
View File

@ -825,7 +825,7 @@ public class Selector implements Selectable, AutoCloseable {
* Clears all the results from the previous poll. This is invoked by Selector at the start of * Clears all the results from the previous poll. This is invoked by Selector at the start of
* a poll() when all the results from the previous poll are expected to have been handled. * a poll() when all the results from the previous poll are expected to have been handled.
* <p> * <p>
* SocketServer uses {@link #clearCompletedSends()} and {@link #clearCompletedSends()} to * SocketServer uses {@link #clearCompletedSends()} and {@link #clearCompletedReceives()} to
* clear `completedSends` and `completedReceives` as soon as they are processed to avoid * clear `completedSends` and `completedReceives` as soon as they are processed to avoid
* holding onto large request/response buffers from multiple connections longer than necessary. * holding onto large request/response buffers from multiple connections longer than necessary.
* Clients rely on Selector invoking {@link #clear()} at the start of each poll() since memory usage * Clients rely on Selector invoking {@link #clear()} at the start of each poll() since memory usage