root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-19313 Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET (#19767)
CI / build (push) Waiting to run Details 

Replaces the UNIFIED_LOG_UNKNOWN_OFFSET constant in LogOffsetMetadata
with UnifiedLog.UNKNOWN_OFFSET.

Reviewers: PoAn Yang <payang@apache.org>, Ken Huang
<s7133700@gmail.com>, YuChia Ma <minecraftmiku831@gmail.com>, Chia-Ping
Tsai <chia7712@gmail.com>
This commit is contained in:
Yu-Syuan Jheng 2025-05-24 11:33:26 -04:00 committed by GitHub
parent 97db06689b
commit 1407b12e2f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java
View File

@ -26,18 +26,16 @@ import org.apache.kafka.common.KafkaException;
*/ */
public final class LogOffsetMetadata { public final class LogOffsetMetadata {
//TODO KAFKA-14484 remove once UnifiedLog has been moved to the storage module
private static final long UNIFIED_LOG_UNKNOWN_OFFSET = -1L;
private static final int UNKNOWN_FILE_POSITION = -1; private static final int UNKNOWN_FILE_POSITION = -1;
public static final LogOffsetMetadata UNKNOWN_OFFSET_METADATA = new LogOffsetMetadata(-1L, UNIFIED_LOG_UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION); public static final LogOffsetMetadata UNKNOWN_OFFSET_METADATA = new LogOffsetMetadata(-1L, UnifiedLog.UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION);
public final long messageOffset; public final long messageOffset;
public final long segmentBaseOffset; public final long segmentBaseOffset;
public final int relativePositionInSegment; public final int relativePositionInSegment;
public LogOffsetMetadata(long messageOffset) { public LogOffsetMetadata(long messageOffset) {
this(messageOffset, UNIFIED_LOG_UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION); this(messageOffset, UnifiedLog.UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION);
} }
public LogOffsetMetadata(long messageOffset, public LogOffsetMetadata(long messageOffset,
@ -75,7 +73,7 @@ public final class LogOffsetMetadata {
// decide if the offset metadata only contains message offset info // decide if the offset metadata only contains message offset info
public boolean messageOffsetOnly() { public boolean messageOffsetOnly() {
return segmentBaseOffset == UNIFIED_LOG_UNKNOWN_OFFSET && relativePositionInSegment == UNKNOWN_FILE_POSITION; return segmentBaseOffset == UnifiedLog.UNKNOWN_OFFSET && relativePositionInSegment == UNKNOWN_FILE_POSITION;
} }
@Override @Override