root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Replace Collection.toArray(new T[size]) by Collection.toArray(new T[0]) (#9750) 

This PR is based on the research of https://shipilev.net/blog/2016/arrays-wisdom-ancients

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
APaMio 2020-12-21 17:38:33 +08:00 committed by GitHub
parent 4e7c789118
commit 1670362236
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clients/src/main/java/org/apache/kafka/common/header/internals/RecordHeaders.java
View File

@ -109,7 +109,7 @@ public class RecordHeaders implements Headers {
}
public Header[] toArray() {
return headers.isEmpty() ? Record.EMPTY_HEADERS : headers.toArray(new Header[headers.size()]);
return headers.isEmpty() ? Record.EMPTY_HEADERS : headers.toArray(new Header[0]);
}
private void checkKey(String key) {

2
clients/src/main/java/org/apache/kafka/common/metrics/stats/Frequencies.java
View File

@ -63,7 +63,7 @@ public class Frequencies extends SampledStat implements CompoundStat {
if (frequencies.isEmpty()) {
throw new IllegalArgumentException("Must specify at least one metric name");
}
Frequency[] frequencyArray = frequencies.toArray(new Frequency[frequencies.size()]);
Frequency[] frequencyArray = frequencies.toArray(new Frequency[0]);
return new Frequencies(2, 0.0, 1.0, frequencyArray);
}

2
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java
View File

@ -241,7 +241,7 @@ public class ScramSaslClient implements SaslClient {
@Override
public String[] getMechanismNames(Map<String, ?> props) {
Collection<String> mechanisms = ScramMechanism.mechanismNames();
return mechanisms.toArray(new String[mechanisms.size()]);
return mechanisms.toArray(new String[0]);
}
}
}

2
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslServer.java
View File

@ -259,7 +259,7 @@ public class ScramSaslServer implements SaslServer {
@Override
public String[] getMechanismNames(Map<String, ?> props) {
Collection<String> mechanisms = ScramMechanism.mechanismNames();
return mechanisms.toArray(new String[mechanisms.size()]);
return mechanisms.toArray(new String[0]);
}
}
}

4
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
View File

@ -133,7 +133,7 @@ public class RestServer {
}
}
jettyServer.setConnectors(connectors.toArray(new Connector[connectors.size()]));
jettyServer.setConnectors(connectors.toArray(new Connector[0]));
if (adminListeners != null && !adminListeners.isEmpty()) {
for (String adminListener : adminListeners) {
@ -300,7 +300,7 @@ public class RestServer {
contextHandlers.add(new DefaultHandler());
contextHandlers.add(requestLogHandler);
handlers.setHandlers(contextHandlers.toArray(new Handler[]{}));
handlers.setHandlers(contextHandlers.toArray(new Handler[0]));
try {
context.start();
} catch (Exception e) {

4
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/util/SSLUtils.java
View File

@ -121,7 +121,7 @@ public class SSLUtils {
@SuppressWarnings("unchecked")
protected static void configureSslContextFactoryAlgorithms(SslContextFactory ssl, Map<String, Object> sslConfigValues) {
List<String> sslEnabledProtocols = (List<String>) getOrDefault(sslConfigValues, SslConfigs.SSL_ENABLED_PROTOCOLS_CONFIG, Arrays.asList(COMMA_WITH_WHITESPACE.split(SslConfigs.DEFAULT_SSL_ENABLED_PROTOCOLS)));
ssl.setIncludeProtocols(sslEnabledProtocols.toArray(new String[sslEnabledProtocols.size()]));
ssl.setIncludeProtocols(sslEnabledProtocols.toArray(new String[0]));
String sslProvider = (String) sslConfigValues.get(SslConfigs.SSL_PROVIDER_CONFIG);
if (sslProvider != null)
@ -131,7 +131,7 @@ public class SSLUtils {
List<String> sslCipherSuites = (List<String>) sslConfigValues.get(SslConfigs.SSL_CIPHER_SUITES_CONFIG);
if (sslCipherSuites != null)
ssl.setIncludeCipherSuites(sslCipherSuites.toArray(new String[sslCipherSuites.size()]));
ssl.setIncludeCipherSuites(sslCipherSuites.toArray(new String[0]));
ssl.setKeyManagerFactoryAlgorithm((String) getOrDefault(sslConfigValues, SslConfigs.SSL_KEYMANAGER_ALGORITHM_CONFIG, SslConfigs.DEFAULT_SSL_KEYMANGER_ALGORITHM));

2
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoinValueGetterSupplier.java
View File

@ -37,7 +37,7 @@ public abstract class KTableKTableAbstractJoinValueGetterSupplier<K, R, V1, V2>
final Set<String> stores = new HashSet<>(storeNames1.length + storeNames2.length);
Collections.addAll(stores, storeNames1);
Collections.addAll(stores, storeNames2);
return stores.toArray(new String[stores.size()]);
return stores.toArray(new String[0]);
}
}

2
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableJoinMerger.java
View File

@ -70,7 +70,7 @@ public class KTableKTableJoinMerger<K, V> implements KTableProcessorSupplier<K,
final Set<String> stores = new HashSet<>(storeNames1.length + storeNames2.length);
Collections.addAll(stores, storeNames1);
Collections.addAll(stores, storeNames2);
return stores.toArray(new String[stores.size()]);
return stores.toArray(new String[0]);
}
};
}

2
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java
View File

@ -84,7 +84,7 @@ public class StreamSourceNode<K, V> extends SourceGraphNode<K, V> {
consumedInternal().timestampExtractor(),
consumedInternal().keyDeserializer(),
consumedInternal().valueDeserializer(),
topicNames().toArray(new String[topicNames().size()]));
topicNames().toArray(new String[0]));
}
}

2
streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowTest.java
View File

@ -128,7 +128,7 @@ public class TimeWindowTest {
final TimeWindows windows = TimeWindows.of(ofMillis(12L)).advanceBy(ofMillis(5L));
final Map<Long, TimeWindow> matched = windows.windowsFor(21L);
final Long[] expected = matched.keySet().toArray(new Long[matched.size()]);
final Long[] expected = matched.keySet().toArray(new Long[0]);
assertEquals(expected[0].longValue(), 10L);
assertEquals(expected[1].longValue(), 15L);
assertEquals(expected[2].longValue(), 20L);

2
tools/src/main/java/org/apache/kafka/trogdor/coordinator/CoordinatorClient.java
View File

@ -174,7 +174,7 @@ public class CoordinatorClient {
public TasksResponse tasks(TasksRequest request) throws Exception {
UriBuilder uriBuilder = UriBuilder.fromPath(url("/coordinator/tasks"));
uriBuilder.queryParam("taskId", (Object[]) request.taskIds().toArray(new String[0]));
uriBuilder.queryParam("taskId", request.taskIds().toArray(new Object[0]));
uriBuilder.queryParam("firstStartMs", request.firstStartMs());
uriBuilder.queryParam("lastStartMs", request.lastStartMs());
uriBuilder.queryParam("firstEndMs", request.firstEndMs());

6
tools/src/main/java/org/apache/kafka/trogdor/fault/DegradedNetworkFaultWorker.java
View File

@ -109,19 +109,19 @@ public class DegradedNetworkFaultWorker implements TaskWorker {
List<String> delay = new ArrayList<>();
rootHandler(networkDevice, delay::add);
netemDelay(delayMs, deviationMs, delay::add);
platform.runCommand(delay.toArray(new String[]{}));
platform.runCommand(delay.toArray(new String[0]));
if (rateLimitKbps > 0) {
List<String> rate = new ArrayList<>();
childHandler(networkDevice, rate::add);
tbfRate(rateLimitKbps, rate::add);
platform.runCommand(rate.toArray(new String[]{}));
platform.runCommand(rate.toArray(new String[0]));
}
} else if (rateLimitKbps > 0) {
List<String> rate = new ArrayList<>();
rootHandler(networkDevice, rate::add);
tbfRate(rateLimitKbps, rate::add);
platform.runCommand(rate.toArray(new String[]{}));
platform.runCommand(rate.toArray(new String[0]));
} else {
log.warn("Not applying any rate limiting or latency");
}