From 210f277910baa71636b51de19b1baa769f57176a Mon Sep 17 00:00:00 2001
From: ShivsundarR <shr@confluent.io>
Date: Tue, 11 Feb 2025 09:53:54 -0500
Subject: [PATCH] Fix bug in json naming (#18858)

Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>, Andrew Schofield <aschofield@confluent.io>
---
 .../kafka/trogdor/workload/ShareConsumeBenchSpec.java     | 2 +-
 .../kafka/trogdor/workload/ShareConsumeBenchSpecTest.java | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/trogdor/src/main/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpec.java b/trogdor/src/main/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpec.java
index 021f04ebd33..503d2b9b827 100644
--- a/trogdor/src/main/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpec.java
+++ b/trogdor/src/main/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpec.java
@@ -98,7 +98,7 @@ public final class ShareConsumeBenchSpec extends TaskSpec {
                             @JsonProperty("bootstrapServers") String bootstrapServers,
                             @JsonProperty("targetMessagesPerSec") int targetMessagesPerSec,
                             @JsonProperty("maxMessages") long maxMessages,
-                            @JsonProperty("consumerGroup") String shareGroup,
+                            @JsonProperty("shareGroup") String shareGroup,
                             @JsonProperty("consumerConf") Map<String, String> consumerConf,
                             @JsonProperty("commonClientConf") Map<String, String> commonClientConf,
                             @JsonProperty("adminClientConf") Map<String, String> adminClientConf,
diff --git a/trogdor/src/test/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpecTest.java b/trogdor/src/test/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpecTest.java
index 76a30b73ec1..0dbd57651eb 100644
--- a/trogdor/src/test/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpecTest.java
+++ b/trogdor/src/test/java/org/apache/kafka/trogdor/workload/ShareConsumeBenchSpecTest.java
@@ -50,6 +50,14 @@ class ShareConsumeBenchSpecTest {
         }
     }
 
+    @Test
+    public void testDefaultShareGroupName() {
+        ShareConsumeBenchSpec shareConsumeBenchSpec = new ShareConsumeBenchSpec(0, 0, "node", "localhost",
+                123, 1234, null, Collections.emptyMap(), Collections.emptyMap(), Collections.emptyMap(), 1,
+                Optional.empty(), List.of("abc"));
+        assertEquals("share", shareConsumeBenchSpec.shareGroup());
+    }
+
     private ShareConsumeBenchSpec shareConsumeBenchSpec(List<String> activeTopics) {
         return new ShareConsumeBenchSpec(0, 0, "node", "localhost",
                 123, 1234, "sg-1",