root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix (#10643) 

Consecutive UUID generation could result in same prefix.

Reviewers: Josep Prat <josep.prat@aiven.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>
This commit is contained in:
Guozhang Wang 2021-05-10 12:32:51 -07:00 committed by GitHub
parent 8a574adcae
commit 25f4ee879c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
View File

@ -74,6 +74,7 @@ import static org.easymock.EasyMock.isNull;
import static org.easymock.EasyMock.mock;
import static org.easymock.EasyMock.notNull;
import static org.easymock.EasyMock.reset;
import static org.hamcrest.CoreMatchers.either;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.notNullValue;
@ -439,6 +440,8 @@ public class RocksDBStoreTest {
final UUID uuid1 = UUID.randomUUID();
final UUID uuid2 = UUID.randomUUID();
final String prefix = uuid1.toString().substring(0, 4);
final int numMatches = uuid2.toString().substring(0, 4).equals(prefix) ? 2 : 1;
entries.add(new KeyValue<>(
new Bytes(uuidSerializer.serialize(null, uuid1)),
stringSerializer.serialize(null, "a")));
@ -460,9 +463,13 @@ public class RocksDBStoreTest {
numberOfKeysReturned++;
}
assertThat(numberOfKeysReturned, is(1));
assertThat(numberOfKeysReturned, is(numMatches));
if (numMatches == 2) {
assertThat(valuesWithPrefix.get(0), either(is("a")).or(is("b")));
} else {
assertThat(valuesWithPrefix.get(0), is("a"));
}
}
@Test
public void shouldReturnNoKeys() {