From 29115d5931556b74af5f7a4e5bd28ca7e42c227a Mon Sep 17 00:00:00 2001
From: David Jacot <david.jacot@gmail.com>
Date: Mon, 3 Mar 2025 18:10:17 +0100
Subject: [PATCH] MINOR: Don't print cleaning group metadata log if empty
 (#19080)

The new group coordinator prints the following line at fixed interval
even if no groups were deleted:

```
Generated 0 tombstone records while cleaning up group metadata in 0 milliseconds. (org.apache.kafka.coordinator.group.GroupCoordinatorShard)
```

The time component has some value in its own but it may be better to not
print if when there are not records in order to reduce the spam in the
logs.

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
---
 .../kafka/coordinator/group/GroupCoordinatorShard.java     | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java
index bbe2f1431ee..88a65ca0ee4 100644
--- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java
+++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java
@@ -753,8 +753,11 @@ public class GroupCoordinatorShard implements CoordinatorShard<CoordinatorRecord
             }
         });
 
-        log.info("Generated {} tombstone records while cleaning up group metadata in {} milliseconds.",
-            records.size(), time.milliseconds() - startMs);
+        if (!records.isEmpty()) {
+            log.info("Generated {} tombstone records while cleaning up group metadata in {} milliseconds.",
+                records.size(), time.milliseconds() - startMs);
+        }
+
         // Reschedule the next cycle.
         scheduleGroupMetadataExpiration();
         return new CoordinatorResult<>(records, false);