From 2aaca8db9d0060a05a71ba65cdccacede1fcc276 Mon Sep 17 00:00:00 2001
From: Kirk True <kirk@kirktrue.pro>
Date: Tue, 23 Sep 2025 17:27:09 -0700
Subject: [PATCH] Move pollForRecords helper method in KafkaConsumerTest

Relocated the pollForRecords() helper method from its previous position to after the testPollIdleRatio method for improved code organization in KafkaConsumerTest.
---
 .../clients/consumer/KafkaConsumerTest.java   | 30 +++++++++----------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
index 50d0b96daea..16faefe0539 100644
--- a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
@@ -2720,22 +2720,6 @@ public class KafkaConsumerTest {
         assertEquals(OptionalLong.of(45L), consumer.currentLag(tp0));
     }
 
-    @SuppressWarnings("unchecked")
-    private ConsumerRecords<String, String> pollForRecords() {
-        Timer timer = time.timer(15000);
-
-        while (timer.notExpired()) {
-            ConsumerRecords<String, String> records = (ConsumerRecords<String, String>) consumer.poll(Duration.ofMillis(1000));
-
-            if (!records.isEmpty())
-                return records;
-        }
-
-        throw new org.apache.kafka.common.errors.TimeoutException("no records to return");
-    }
-
-
-
     @ParameterizedTest
     @EnumSource(GroupProtocol.class)
     public void testListOffsetShouldUpdateSubscriptions(GroupProtocol groupProtocol) {
@@ -3816,6 +3800,20 @@ public void testPollIdleRatio(GroupProtocol groupProtocol) {
         return new MetricName(NAME, "plugins", DESCRIPTION, expectedTags);
     }
 
+    @SuppressWarnings("unchecked")
+    private ConsumerRecords<String, String> pollForRecords() {
+        Timer timer = time.timer(15000);
+
+        while (timer.notExpired()) {
+            ConsumerRecords<String, String> records = (ConsumerRecords<String, String>) consumer.poll(Duration.ofMillis(1000));
+
+            if (!records.isEmpty())
+                return records;
+        }
+
+        throw new org.apache.kafka.common.errors.TimeoutException("no records to return");
+    }
+
     private void waitForConsumerPoll(Supplier<Boolean> testCondition, String conditionDetails) {
         try {
             TestUtils.waitForCondition(