root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Remove unnecessary checks in `TopicDelta` (#20337) 

field `directories` has already been validated in the constructor,so
there’s no need to check for null.


7d2ad18520/metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java (L221)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, TengYao Chi
<frankvicky@apache.org>, Yung <yungyung7654321@gmail.com>, Ken Huang
<s7133700@gmail.com>
This commit is contained in:
Xuan-Zhang Gong 2025-08-12 12:37:18 +08:00 committed by GitHub
parent 9a0239a032
commit 2e774cca4f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java
View File

@ -211,11 +211,7 @@ public final class TopicDelta {
try { try {
PartitionRegistration prevPartition = image.partitions().get(entry.getKey()); PartitionRegistration prevPartition = image.partitions().get(entry.getKey());
if ( if (prevPartition == null || prevPartition.directory(brokerId) != entry.getValue().directory(brokerId)) {
prevPartition == null ||
prevPartition.directories == null ||
prevPartition.directory(brokerId) != entry.getValue().directory(brokerId)
) {
directoryIds.put( directoryIds.put(
new TopicIdPartition(id(), new TopicPartition(name(), entry.getKey())), new TopicIdPartition(id(), new TopicPartition(name(), entry.getKey())),
entry.getValue().directory(brokerId) entry.getValue().directory(brokerId)