root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: fix client_compatibility_features_test.py (#10292) 

Reviewers: Colin Patrick McCabe <cmccabe@confluent.io>, Ron Dagostino <rdagostino@confluent.io>
This commit is contained in:
Chia-Ping Tsai 2021-03-18 01:27:06 +08:00 committed by GitHub
parent 28ee656081
commit 3288db5ed1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/kafkatest/tests/client/client_compatibility_features_test.py
View File

@ -79,6 +79,9 @@ class ClientCompatibilityFeaturesTest(Test):
"replication-factor": 3
}}
self.kafka = KafkaService(test_context, num_nodes=3, zk=self.zk, topics=self.topics)
# Always use the latest version of org.apache.kafka.tools.ClientCompatibilityTest
# so store away the path to the DEV version before we set the Kafka version
self.dev_script_path = self.kafka.path.script("kafka-run-class.sh", self.kafka.nodes[0])
def invoke_compatibility_program(self, features):
# Run the compatibility test on the first Kafka node.
@ -86,7 +89,7 @@ class ClientCompatibilityFeaturesTest(Test):
cmd = ("%s org.apache.kafka.tools.ClientCompatibilityTest "
"--bootstrap-server %s "
"--num-cluster-nodes %d "
"--topic %s " % (self.kafka.path.script("kafka-run-class.sh", node),
"--topic %s " % (self.dev_script_path,
self.kafka.bootstrap_servers(),
len(self.kafka.nodes),
list(self.topics.keys())[0]))
@ -130,4 +133,8 @@ class ClientCompatibilityFeaturesTest(Test):
self.kafka.set_version(KafkaVersion(broker_version))
self.kafka.start()
features = get_broker_features(broker_version)
if not self.zk:
# this check/disabling is only necessary due to the fact that we are in early access mode with
# KIP-500 and we should remove the special casing when that his fully implemented
features["describe-acls-supported"] = False
self.invoke_compatibility_program(features)