From 342a8e677340d19ad7c3f21b5664a6d629bdd9d3 Mon Sep 17 00:00:00 2001 From: "Matthias J. Sax" Date: Mon, 1 Sep 2025 11:12:11 -0700 Subject: [PATCH] MINOR: suppress build warning (#20424) Suppress build warning. Reviewers: TengYao Chi , Ken Huang , Chia-Ping Tsai --- .../apache/kafka/clients/ClientsTestUtils.java | 2 +- .../MetricsDuringTopicCreationDeletionTest.java | 1 + .../clients/admin/ClientTelemetryTest.java | 2 ++ .../kafka/connect/runtime/WorkerTestUtils.java | 1 + .../server/share/DelayedShareFetchTest.java | 5 +++++ .../server/share/SharePartitionManagerTest.java | 2 +- .../kafka/server/share/SharePartitionTest.java | 2 ++ .../metrics/ControllerMetadataMetricsTest.java | 1 + .../metrics/QuorumControllerMetricsTest.java | 1 + .../kafka/server/util/CommandLineUtilsTest.java | 17 +++++++++-------- .../server/quota/ClientQuotasRequestTest.java | 1 + .../TopicBasedRemoteLogMetadataManagerTest.java | 2 ++ .../remote/storage/RemoteLogManagerTest.java | 5 +++++ .../internals/RecordCollectorTest.java | 4 ++-- 14 files changed, 34 insertions(+), 12 deletions(-) diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java index dfdadeb5090..a007035e860 100644 --- a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java +++ b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java @@ -311,7 +311,7 @@ public class ClientsTestUtils { Optional> offsetsOpt ) throws InterruptedException { - var commitCallback = new RetryCommitCallback(consumer, offsetsOpt); + var commitCallback = new RetryCommitCallback<>(consumer, offsetsOpt); sendAsyncCommit(consumer, commitCallback, offsetsOpt); TestUtils.waitForCondition(() -> { diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java index 32a8e5192f9..f79ddabd8ca 100644 --- a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java +++ b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java @@ -137,6 +137,7 @@ public class MetricsDuringTopicCreationDeletionTest { } } + @SuppressWarnings("unchecked") private Gauge getGauge(String metricName) { return KafkaYammerMetrics.defaultRegistry().allMetrics().entrySet().stream() .filter(entry -> entry.getKey().getName().endsWith(metricName)) diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java index 4629cb3b078..ab05b753c54 100644 --- a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java +++ b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java @@ -123,6 +123,7 @@ public class ClientTelemetryTest { } } + @SuppressWarnings("unchecked") @ClusterTest(types = {Type.CO_KRAFT, Type.KRAFT}) public void testIntervalMsParser(ClusterInstance clusterInstance) { List alterOpts = asList("--bootstrap-server", clusterInstance.bootstrapServers(), @@ -152,6 +153,7 @@ public class ClientTelemetryTest { } } + @SuppressWarnings("unchecked") private static String[] toArray(List... lists) { return Stream.of(lists).flatMap(List::stream).toArray(String[]::new); } diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java index 414b3cf87c5..0546e3bb4e9 100644 --- a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java +++ b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java @@ -168,6 +168,7 @@ public class WorkerTestUtils { "Wrong rebalance delay in " + assignment); } + @SuppressWarnings("unchecked") public static > TransformationChain getTransformationChain( RetryWithToleranceOperator toleranceOperator, List results) { diff --git a/core/src/test/java/kafka/server/share/DelayedShareFetchTest.java b/core/src/test/java/kafka/server/share/DelayedShareFetchTest.java index 23f32659189..ffa9f8b1145 100644 --- a/core/src/test/java/kafka/server/share/DelayedShareFetchTest.java +++ b/core/src/test/java/kafka/server/share/DelayedShareFetchTest.java @@ -1278,6 +1278,7 @@ public class DelayedShareFetchTest { assertEquals(1, delayedShareFetch.expiredRequestMeter().count()); } + @SuppressWarnings("unchecked") @Test public void testRemoteStorageFetchTryCompleteReturnsFalse() { ReplicaManager replicaManager = mock(ReplicaManager.class); @@ -1357,6 +1358,7 @@ public class DelayedShareFetchTest { delayedShareFetch.lock().unlock(); } + @SuppressWarnings("unchecked") @Test public void testRemoteStorageFetchPartitionLeaderChanged() { ReplicaManager replicaManager = mock(ReplicaManager.class); @@ -1421,6 +1423,7 @@ public class DelayedShareFetchTest { delayedShareFetch.lock().unlock(); } + @SuppressWarnings("unchecked") @Test public void testRemoteStorageFetchTryCompleteThrowsException() { ReplicaManager replicaManager = mock(ReplicaManager.class); @@ -1507,6 +1510,7 @@ public class DelayedShareFetchTest { delayedShareFetch.lock().unlock(); } + @SuppressWarnings("unchecked") @Test public void testRemoteStorageFetchTryCompletionDueToBrokerBecomingOffline() { ReplicaManager replicaManager = mock(ReplicaManager.class); @@ -2197,6 +2201,7 @@ public class DelayedShareFetchTest { return mock(BiConsumer.class); } + @SuppressWarnings("unchecked") static class DelayedShareFetchBuilder { private ShareFetch shareFetch = mock(ShareFetch.class); private ReplicaManager replicaManager = mock(ReplicaManager.class); diff --git a/core/src/test/java/kafka/server/share/SharePartitionManagerTest.java b/core/src/test/java/kafka/server/share/SharePartitionManagerTest.java index 399a8dee761..24a84bab64a 100644 --- a/core/src/test/java/kafka/server/share/SharePartitionManagerTest.java +++ b/core/src/test/java/kafka/server/share/SharePartitionManagerTest.java @@ -2470,7 +2470,6 @@ public class SharePartitionManagerTest { } @Test - @SuppressWarnings("unchecked") public void testShareFetchProcessingExceptions() throws Exception { String groupId = "grp"; TopicIdPartition tp0 = new TopicIdPartition(Uuid.randomUuid(), new TopicPartition("foo", 0)); @@ -3232,6 +3231,7 @@ public class SharePartitionManagerTest { return CollectionConverters.asScala(logReadResults).toSeq(); } + @SuppressWarnings("unchecked") static void mockReplicaManagerDelayedShareFetch(ReplicaManager replicaManager, DelayedOperationPurgatory delayedShareFetchPurgatory) { doAnswer(invocationOnMock -> { diff --git a/core/src/test/java/kafka/server/share/SharePartitionTest.java b/core/src/test/java/kafka/server/share/SharePartitionTest.java index d1c6f9977b0..25432b4ae15 100644 --- a/core/src/test/java/kafka/server/share/SharePartitionTest.java +++ b/core/src/test/java/kafka/server/share/SharePartitionTest.java @@ -110,6 +110,7 @@ import static org.mockito.ArgumentMatchers.anyList; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; +@SuppressWarnings("resource") public class SharePartitionTest { private static final String ACQUISITION_LOCK_NEVER_GOT_RELEASED = "Acquisition lock never got released."; @@ -7991,6 +7992,7 @@ public class SharePartitionTest { assertNotNull(sharePartition.cachedState().get(50L).offsetState().get(69L).acquisitionLockTimeoutTask()); } + @SuppressWarnings({"rawtypes", "unchecked"}) @Test public void testContainsAbortMarker() { SharePartition sharePartition = SharePartitionBuilder.builder() diff --git a/metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsTest.java b/metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsTest.java index b06c13ec749..d3a8d73b4f5 100644 --- a/metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsTest.java +++ b/metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsTest.java @@ -160,6 +160,7 @@ public class ControllerMetadataMetricsTest { ); } + @SuppressWarnings("unchecked") // suppress warning about Gauge typecast @Test public void testBrokerRegistrationStateMetrics() { MetricsRegistry registry = new MetricsRegistry(); diff --git a/metadata/src/test/java/org/apache/kafka/controller/metrics/QuorumControllerMetricsTest.java b/metadata/src/test/java/org/apache/kafka/controller/metrics/QuorumControllerMetricsTest.java index cb4eb63bab6..491d22f1cd8 100644 --- a/metadata/src/test/java/org/apache/kafka/controller/metrics/QuorumControllerMetricsTest.java +++ b/metadata/src/test/java/org/apache/kafka/controller/metrics/QuorumControllerMetricsTest.java @@ -164,6 +164,7 @@ public class QuorumControllerMetricsTest { } } + @SuppressWarnings("unchecked") @Test public void testTimeSinceLastHeartbeatReceivedMs() { MetricsRegistry registry = new MetricsRegistry(); diff --git a/server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java b/server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java index a634b21403e..9073db0106b 100644 --- a/server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java +++ b/server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java @@ -55,8 +55,8 @@ public class CommandLineUtilsTest { List argArray = List.of("my.empty.property=", "my.empty.property1"); Properties props = CommandLineUtils.parseKeyValueArgs(argArray); - assertEquals(props.getProperty("my.empty.property"), "", "Value of a key with missing value should be an empty string"); - assertEquals(props.getProperty("my.empty.property1"), "", "Value of a key with missing value with no delimiter should be an empty string"); + assertEquals("", props.getProperty("my.empty.property"), "Value of a key with missing value should be an empty string"); + assertEquals("", props.getProperty("my.empty.property1"), "Value of a key with missing value with no delimiter should be an empty string"); } @Test @@ -64,7 +64,7 @@ public class CommandLineUtilsTest { List argArray = List.of("my.property=value"); Properties props = CommandLineUtils.parseKeyValueArgs(argArray); - assertEquals(props.getProperty("my.property"), "value", "Value of a single property should be 'value'"); + assertEquals("value", props.getProperty("my.property"), "Value of a single property should be 'value'"); } @Test @@ -72,8 +72,8 @@ public class CommandLineUtilsTest { List argArray = List.of("first.property=first", "second.property=second"); Properties props = CommandLineUtils.parseKeyValueArgs(argArray); - assertEquals(props.getProperty("first.property"), "first", "Value of first property should be 'first'"); - assertEquals(props.getProperty("second.property"), "second", "Value of second property should be 'second'"); + assertEquals("first", props.getProperty("first.property"), "Value of first property should be 'first'"); + assertEquals("second", props.getProperty("second.property"), "Value of second property should be 'second'"); } @Test @@ -81,9 +81,9 @@ public class CommandLineUtilsTest { List argArray = List.of("first.property==first", "second.property=second=", "third.property=thi=rd"); Properties props = CommandLineUtils.parseKeyValueArgs(argArray); - assertEquals(props.getProperty("first.property"), "=first", "Value of first property should be '=first'"); - assertEquals(props.getProperty("second.property"), "second=", "Value of second property should be 'second='"); - assertEquals(props.getProperty("third.property"), "thi=rd", "Value of second property should be 'thi=rd'"); + assertEquals("=first", props.getProperty("first.property"), "Value of first property should be '=first'"); + assertEquals("second=", props.getProperty("second.property"), "Value of second property should be 'second='"); + assertEquals("thi=rd", props.getProperty("third.property"), "Value of second property should be 'thi=rd'"); } Properties props = new Properties(); @@ -272,6 +272,7 @@ public class CommandLineUtilsTest { Optional.of("127.0.0.2:9094"), Optional.of("127.0.0.3:9095"))).getMessage()); } + @SuppressWarnings("unchecked") private OptionSpec createMockOptionSpec(String name) { OptionSpec spec = mock(OptionSpec.class); when(spec.toString()).thenReturn("[" + name.replaceAll("--", "") + "]"); diff --git a/server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java b/server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java index a4d562a5543..5f92d700f71 100644 --- a/server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java +++ b/server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java @@ -479,6 +479,7 @@ public class ClientQuotasRequestTest { } } + @SuppressWarnings("unchecked") private void testMatchEntities(ClientQuotaFilter filter, int expectedMatchSize, Predicate partition) throws InterruptedException { TestUtils.retryOnExceptionWithTimeout(5000L, () -> { diff --git a/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java b/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java index 14404845fe1..c3a5beebad9 100644 --- a/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java +++ b/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java @@ -60,6 +60,7 @@ import static org.mockito.Mockito.spy; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; +@SuppressWarnings("resource") @ClusterTestDefaults(brokers = 3) public class TopicBasedRemoteLogMetadataManagerTest { private static final int SEG_SIZE = 1048576; @@ -106,6 +107,7 @@ public class TopicBasedRemoteLogMetadataManagerTest { } } + @SuppressWarnings("unchecked") @ClusterTest public void testDoesTopicExistWithAdminClientExecutionError() throws ExecutionException, InterruptedException { // Create a mock Admin client that throws an ExecutionException (not UnknownTopicOrPartitionException) diff --git a/storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java b/storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java index b45b1118f5c..403d7ca70ad 100644 --- a/storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java +++ b/storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java @@ -381,6 +381,7 @@ public class RemoteLogManagerTest { assertFalse(remoteStorageManagerConfig.containsKey("remote.storage.manager.y")); } + @SuppressWarnings("unchecked") @Test void testRemoteLogMetadataManagerWithEndpointConfig() { ArgumentCaptor> capture = ArgumentCaptor.forClass(Map.class); @@ -391,6 +392,7 @@ public class RemoteLogManagerTest { assertEquals(brokerId, capture.getValue().get(ServerConfigs.BROKER_ID_CONFIG)); } + @SuppressWarnings("unchecked") @Test void testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOException { Properties props = new Properties(); @@ -430,6 +432,7 @@ public class RemoteLogManagerTest { } } + @SuppressWarnings("unchecked") @Test void testConfigure() { ArgumentCaptor> capture = ArgumentCaptor.forClass(Map.class); @@ -2071,6 +2074,7 @@ public class RemoteLogManagerTest { assertEquals(expected, actual); } + @SuppressWarnings("unchecked") @Test public void testRemoteSizeData() { Supplier[] invalidRetentionSizeData = @@ -2087,6 +2091,7 @@ public class RemoteLogManagerTest { } } + @SuppressWarnings("unchecked") @Test public void testRemoteSizeTime() { Supplier[] invalidRetentionTimeData = diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java index 7f812da3e49..4923700666f 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java @@ -1961,6 +1961,7 @@ public class RecordCollectorTest { } + @SuppressWarnings("deprecation") @Override public ProductionExceptionHandlerResponse handle(final ErrorHandlerContext context, final ProducerRecord record, final Exception exception) { sourceRawData[0] = context.sourceRawKey(); @@ -1978,15 +1979,14 @@ public class RecordCollectorTest { assertNull(sourceRawData[1]); } - @Test public void shouldHaveRawDataDuringExceptionInSerialization() { final byte[][] sourceRawData = new byte[][]{new byte[]{}, new byte[]{}}; try (final ErrorStringSerializer errorSerializer = new ErrorStringSerializer()) { final RecordCollector collector = newRecordCollector( new ProductionExceptionHandler() { + @SuppressWarnings({"deprecation", "rawtypes"}) @Override - @SuppressWarnings({"rawtypes", "unused"}) public ProductionExceptionHandlerResponse handleSerializationException(final ErrorHandlerContext context, final ProducerRecord record, final Exception exception, final SerializationExceptionOrigin origin) { sourceRawData[0] = context.sourceRawKey(); sourceRawData[1] = context.sourceRawValue();