root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Fix incorrect example in feature command help (#12732) 

When using `kafka-features.sh` with the `--feature` parameter, we expect a numeric feature level (e.g. `metadata.version=5`). The help example suggests that we can also use a descriptive version string for `metadata.version` such as `3.3-IV3`, which doesn't work.

Reviewers: David Jacot <djacot@confluent.io>
This commit is contained in:
Jason Gustafson 2022-10-12 11:04:55 -07:00 committed by Colin P. McCabe
parent e8c6a7bb69
commit 3acf1514b7
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/main/scala/kafka/admin/FeatureCommand.scala
View File

@ -113,7 +113,7 @@ object FeatureCommand {
.help("The level to which we should upgrade the metadata. For example, 3.3-IV3.")
.action(store())
upgradeParser.addArgument("--feature")
.help("A feature upgrade we should perform, in key=value format. For example metadata.version=3.3-IV3.")
.help("A feature upgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
.action(append())
upgradeParser.addArgument("--dry-run")
.help("Validate this upgrade, but do not perform it.")
@ -127,8 +127,7 @@ object FeatureCommand {
.help("The level to which we should downgrade the metadata. For example, 3.3-IV0.")
.action(store())
downgradeParser.addArgument("--feature")
.help("A feature downgrade we should perform, in key=value format. " +
"For example metadata.version=3.3-IV0.")
.help("A feature downgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
.action(append())
downgradeParser.addArgument("--unsafe")
.help("Perform this downgrade even if it may irreversibly destroy metadata.")