From 3bb408c4de7875fc7536f94fb9b086eb7867d015 Mon Sep 17 00:00:00 2001 From: TaiJuWu Date: Sat, 5 Oct 2024 05:50:48 +0800 Subject: [PATCH] MINOR: rename ConfigName.RENAME to ConfigName.RENAMES for replaceFiled (#17369) Reviewers: Andrew Schofield , TengYao Chi , Chia-Ping Tsai --- .../java/org/apache/kafka/connect/transforms/Cast.java | 2 +- .../org/apache/kafka/connect/transforms/ReplaceField.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java b/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java index cc5319ef9c7..ffc0c8b8b71 100644 --- a/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java +++ b/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java @@ -412,7 +412,7 @@ public abstract class Cast> implements Transformation for (String mapping : mappings) { final String[] parts = mapping.split(":"); if (parts.length > 2) { - throw new ConfigException(ReplaceField.ConfigName.RENAME, mappings, "Invalid rename mapping: " + mapping); + throw new ConfigException(ReplaceField.ConfigName.RENAMES, mappings, "Invalid rename mapping: " + mapping); } if (parts.length == 1) { Schema.Type targetType; diff --git a/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java b/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java index 6f337e4632a..38d27e8a818 100644 --- a/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java +++ b/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java @@ -51,7 +51,7 @@ public abstract class ReplaceField> implements Transf String EXCLUDE = "exclude"; String INCLUDE = "include"; - String RENAME = "renames"; + String RENAMES = "renames"; String REPLACE_NULL_WITH_DEFAULT_CONFIG = "replace.null.with.default"; } @@ -60,7 +60,7 @@ public abstract class ReplaceField> implements Transf "Fields to exclude. This takes precedence over the fields to include.") .define(ConfigName.INCLUDE, ConfigDef.Type.LIST, Collections.emptyList(), ConfigDef.Importance.MEDIUM, "Fields to include. If specified, only these fields will be used.") - .define(ConfigName.RENAME, ConfigDef.Type.LIST, Collections.emptyList(), + .define(ConfigName.RENAMES, ConfigDef.Type.LIST, Collections.emptyList(), ConfigDef.LambdaValidator.with( (name, value) -> { @SuppressWarnings("unchecked") @@ -93,7 +93,7 @@ public abstract class ReplaceField> implements Transf exclude = new HashSet<>(config.getList(ConfigName.EXCLUDE)); include = new HashSet<>(config.getList(ConfigName.INCLUDE)); - renames = parseRenameMappings(config.getList(ConfigName.RENAME)); + renames = parseRenameMappings(config.getList(ConfigName.RENAMES)); reverseRenames = invert(renames); replaceNullWithDefault = config.getBoolean(ConfigName.REPLACE_NULL_WITH_DEFAULT_CONFIG); @@ -105,7 +105,7 @@ public abstract class ReplaceField> implements Transf for (String mapping : mappings) { final String[] parts = mapping.split(":"); if (parts.length != 2) { - throw new ConfigException(ConfigName.RENAME, mappings, "Invalid rename mapping: " + mapping); + throw new ConfigException(ConfigName.RENAMES, mappings, "Invalid rename mapping: " + mapping); } m.put(parts[0], parts[1]); }