root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-15153: Use Python 'is' instead of '==' to compare for None (#13964) 

Reviewers: Divij Vaidya <diviv@amazon.com>

Co-authored-by: d00791190 <dinglan6@huawei.com>
This commit is contained in:
DL1231 2023-07-06 22:59:13 +08:00 committed by GitHub
parent a1a3ec0bcb
commit 4149e31cad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
release_notes.py
View File

@ -44,7 +44,7 @@ def get_issues(jira, query, **kwargs):
results = [] results = []
startAt = 0 startAt = 0
new_results = None new_results = None
while new_results == None or len(new_results) == MAX_RESULTS: while new_results is None or len(new_results) == MAX_RESULTS:
new_results = jira.search_issues(query, startAt=startAt, maxResults=MAX_RESULTS, **kwargs) new_results = jira.search_issues(query, startAt=startAt, maxResults=MAX_RESULTS, **kwargs)
results += new_results results += new_results
startAt += len(new_results) startAt += len(new_results)

2
tests/kafkatest/tests/client/consumer_test.py
View File

@ -334,7 +334,7 @@ class OffsetValidationTest(VerifiableConsumerTest):
# stop the partition owner and await its shutdown # stop the partition owner and await its shutdown
consumer.kill_node(partition_owner, clean_shutdown=clean_shutdown) consumer.kill_node(partition_owner, clean_shutdown=clean_shutdown)
wait_until(lambda: len(consumer.joined_nodes()) == (self.num_consumers - 1) and consumer.owner(partition) != None, wait_until(lambda: len(consumer.joined_nodes()) == (self.num_consumers - 1) and consumer.owner(partition) is not None,
timeout_sec=self.session_timeout_sec*2+5, timeout_sec=self.session_timeout_sec*2+5,
err_msg="Timed out waiting for consumer to close") err_msg="Timed out waiting for consumer to close")

2
tests/kafkatest/tests/connect/connect_test.py
View File

@ -79,7 +79,7 @@ class ConnectStandaloneFileTest(Test):
parameterizations to test different converters (which also test per-connector converter overrides), schema/schemaless parameterizations to test different converters (which also test per-connector converter overrides), schema/schemaless
modes, and security support. modes, and security support.
""" """
assert converter != None, "converter type must be set" assert converter is not None, "converter type must be set"
# Template parameters. Note that we don't set key/value.converter. These default to JsonConverter and we validate # Template parameters. Note that we don't set key/value.converter. These default to JsonConverter and we validate
# converter overrides via the connector configuration. # converter overrides via the connector configuration.
if converter != "org.apache.kafka.connect.json.JsonConverter": if converter != "org.apache.kafka.connect.json.JsonConverter":