diff --git a/metadata/src/main/java/org/apache/kafka/metadata/placement/PartitionAssignment.java b/metadata/src/main/java/org/apache/kafka/metadata/placement/PartitionAssignment.java index b5c240f53b8..92373df1fe4 100644 --- a/metadata/src/main/java/org/apache/kafka/metadata/placement/PartitionAssignment.java +++ b/metadata/src/main/java/org/apache/kafka/metadata/placement/PartitionAssignment.java @@ -31,7 +31,7 @@ import java.util.Objects; public class PartitionAssignment { private final List replicas; - public PartitionAssignment(final List replicas) { + public PartitionAssignment(List replicas) { this.replicas = Collections.unmodifiableList(new ArrayList<>(replicas)); } @@ -53,4 +53,11 @@ public class PartitionAssignment { public int hashCode() { return Objects.hash(replicas); } + + @Override + public String toString() { + return "PartitionAssignment" + + "(replicas=" + replicas + + ")"; + } } diff --git a/metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java b/metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java index 2b1f24c2827..c5574819c0a 100644 --- a/metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java +++ b/metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java @@ -30,7 +30,7 @@ import java.util.Objects; public class TopicAssignment { private final List assignments; - public TopicAssignment(final List assignments) { + public TopicAssignment(List assignments) { this.assignments = Collections.unmodifiableList(new ArrayList<>(assignments)); } @@ -52,4 +52,11 @@ public class TopicAssignment { public int hashCode() { return Objects.hash(assignments); } + + @Override + public String toString() { + return "TopicAssignment" + + "(assignments=" + assignments + + ")"; + } } diff --git a/metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java b/metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java index 3d962524a2e..b5aacc71525 100644 --- a/metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java +++ b/metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java @@ -57,4 +57,11 @@ public class PartitionAssignmentTest { } } } + + @Test + public void testToString() { + List replicas = Arrays.asList(0, 1, 2); + PartitionAssignment partitionAssignment = new PartitionAssignment(replicas); + assertEquals("PartitionAssignment(replicas=[0, 1, 2])", partitionAssignment.toString()); + } } diff --git a/metadata/src/test/java/org/apache/kafka/metadata/placement/TopicAssignmentTest.java b/metadata/src/test/java/org/apache/kafka/metadata/placement/TopicAssignmentTest.java index d66ceaba3c2..61b2cbd6fa0 100644 --- a/metadata/src/test/java/org/apache/kafka/metadata/placement/TopicAssignmentTest.java +++ b/metadata/src/test/java/org/apache/kafka/metadata/placement/TopicAssignmentTest.java @@ -33,7 +33,7 @@ public class TopicAssignmentTest { List replicasP1 = Arrays.asList(1, 2, 0); List partitionAssignments = Arrays.asList( new PartitionAssignment(replicasP0), - new PartitionAssignment(replicasP1) + new PartitionAssignment(replicasP1) ); assertEquals(partitionAssignments, new TopicAssignment(partitionAssignments).assignments()); } @@ -53,7 +53,7 @@ public class TopicAssignmentTest { new PartitionAssignment( Arrays.asList(1, 2, 0) ) - ) + ) ) ); @@ -70,4 +70,14 @@ public class TopicAssignmentTest { } } } + + @Test + public void testToString() { + List replicas = Arrays.asList(0, 1, 2); + List partitionAssignments = Arrays.asList( + new PartitionAssignment(replicas) + ); + TopicAssignment topicAssignment = new TopicAssignment(partitionAssignments); + assertEquals("TopicAssignment(assignments=[PartitionAssignment(replicas=[0, 1, 2])])", topicAssignment.toString()); + } }