root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Use Exit.addShutdownHook instead of directly adding hooks to Runtime (#12283) 

Reviewers: Mickael Maison <mickael.maison@gmail.com>, Igor Soarez  <soarez@apple.com>, Kvicii <kvicii.yu@gmail.com>
This commit is contained in:
Divij Vaidya 2022-06-13 17:25:40 +02:00 committed by GitHub
parent 89c057397e
commit 4426b05e54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java
View File

@ -22,6 +22,7 @@ import com.yammer.metrics.core.MetricsRegistry;
import org.apache.kafka.common.Reconfigurable;
import org.apache.kafka.common.config.ConfigException;
import org.apache.kafka.common.metrics.JmxReporter;
import org.apache.kafka.common.utils.Exit;
import org.apache.kafka.common.utils.Sanitizer;
import java.util.Iterator;
@ -57,7 +58,7 @@ public class KafkaYammerMetrics implements Reconfigurable {
private KafkaYammerMetrics() {
jmxReporter.start();
Runtime.getRuntime().addShutdownHook(new Thread(jmxReporter::shutdown));
Exit.addShutdownHook("kafka-jmx-shutdown-hook", jmxReporter::shutdown);
}
@Override