root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

KAFKA-3235: Unclosed stream in AppInfoParser static block 

Always close the stream

Author: Kim Christensen <kich@mvno.dk>

Reviewers: Ismael Juma, Grant Henke

Closes #914 from kichristensen/KAFKA-3235
This commit is contained in:
Kim Christensen 2016-02-21 22:54:40 -08:00 committed by Gwen Shapira
parent 6ebb2363ba
commit 49fd0ceb09
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java
View File

@ -16,6 +16,7 @@
*/ */
package org.apache.kafka.common.utils; package org.apache.kafka.common.utils;
import java.io.InputStream;
import java.lang.management.ManagementFactory; import java.lang.management.ManagementFactory;
import java.util.Properties; import java.util.Properties;
@ -32,9 +33,9 @@ public class AppInfoParser {
private static String commitId = "unknown"; private static String commitId = "unknown";
static { static {
try { try (InputStream resourceStream = AppInfoParser.class.getResourceAsStream("/kafka/kafka-version.properties")) {
Properties props = new Properties(); Properties props = new Properties();
props.load(AppInfoParser.class.getResourceAsStream("/kafka/kafka-version.properties")); props.load(resourceStream);
version = props.getProperty("version", version).trim(); version = props.getProperty("version", version).trim();
commitId = props.getProperty("commitId", commitId).trim(); commitId = props.getProperty("commitId", commitId).trim();
} catch (Exception e) { } catch (Exception e) {