From 4a6287e832c35593f851ce8ea427741bcb7d90d1 Mon Sep 17 00:00:00 2001 From: Colin Patrick McCabe Date: Mon, 2 May 2022 09:06:16 -0700 Subject: [PATCH] MINOR: fix ClientQuotasRequestTest (#12107) Fix ClientQuotasRequestTest.testAlterClientQuotasBadIp so that it uses actually unresolvable hostnames. The previous choices "ip" and "abc-123" are now resolvable. Reviewers: David Jacot , Andrew Choi , Divij Vaidya --- .../scala/unit/kafka/server/ClientQuotasRequestTest.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala b/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala index 573bd95b96b..71321c1f208 100644 --- a/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala +++ b/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala @@ -294,8 +294,8 @@ class ClientQuotasRequestTest(cluster: ClusterInstance) { @ClusterTest def testAlterClientQuotasBadIp(): Unit = { - val invalidHostPatternEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.IP -> "abc-123").asJava) - val unresolvableHostEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.IP -> "ip").asJava) + val invalidHostPatternEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.IP -> "not a valid host because it has spaces").asJava) + val unresolvableHostEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.IP -> "RFC2606.invalid").asJava) val expectedExceptionMessage = "not a valid IP" expectInvalidRequestWithMessage(alterEntityQuotas(invalidHostPatternEntity, Map(IpConnectionRateProp -> Some(50.0)), validateOnly = true), expectedExceptionMessage)