root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-18461 Add Objects.requireNotNull to Snapshot (#18684) 

Add explicit not-null checks in Snapshot so we get a better error message in the event that a Snapshot object is accessed after erase has been called.

Reviewers: David Arthur <mumrah@gmail.com>
This commit is contained in:
leaf-soba 2025-03-07 22:48:09 +08:00 committed by GitHub
parent a6064e0800
commit 53b2935c51
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java
View File

@ -19,6 +19,7 @@ package org.apache.kafka.timeline;
import java.util.IdentityHashMap;
import java.util.Map;
import java.util.Objects;
/**
* A snapshot of some timeline data structures.
@ -47,16 +48,19 @@ class Snapshot {
}
void setDelta(Revertable owner, Delta delta) {
Objects.requireNonNull(map, "Snapshot cannot be accessed after erase is called.");
map.put(owner, delta);
}
void handleRevert() {
Objects.requireNonNull(map, "Snapshot cannot be accessed after erase is called.");
for (Map.Entry<Revertable, Delta> entry : map.entrySet()) {
entry.getKey().executeRevert(epoch, entry.getValue());
}
}
void mergeFrom(Snapshot source) {
Objects.requireNonNull(map, "Snapshot cannot be accessed after erase is called.");
// Merge the deltas from the source snapshot into this snapshot.
for (Map.Entry<Revertable, Delta> entry : source.map.entrySet()) {
// We first try to just copy over the object reference. That will work if