root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: speed up connect startup when full connector class name is provided 

Author: Jason Gustafson <jason@confluent.io>

Reviewers: Liquan Pei <liquanpei@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #746 from hachikuji/worker-startup-improvement
This commit is contained in:
Jason Gustafson 2016-01-08 15:04:27 -08:00 committed by Ewen Cheslack-Postava
parent ccdf552749
commit 58def1cba0
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
View File

@ -202,9 +202,18 @@ public class Worker {
return SinkConnector.class.isAssignableFrom(connectors.get(connName).getClass());
}
// Iterate over our entire classpath to find all the connectors and hopefully one of them matches the alias from the connector configration
private Class<? extends Connector> getConnectorClass(String connectorAlias) {
// Avoid the classpath scan if the full class name was provided
try {
Class<?> clazz = Class.forName(connectorAlias);
if (!Connector.class.isAssignableFrom(clazz))
throw new ConnectException("Class " + connectorAlias + " does not implement Connector");
return (Class<? extends Connector>) clazz;
} catch (ClassNotFoundException e) {
// Fall through to scan for the alias
}
// Iterate over our entire classpath to find all the connectors and hopefully one of them matches the alias from the connector configration
Reflections reflections = new Reflections(new ConfigurationBuilder()
.setUrls(ClasspathHelper.forJavaClassPath()));
@ -213,10 +222,6 @@ public class Worker {
List<Class<? extends Connector>> results = new ArrayList<>();
for (Class<? extends Connector> connector: connectors) {
// Configuration included the fully qualified class name
if (connector.getName().equals(connectorAlias))
results.add(connector);
// Configuration included the class name but not package
if (connector.getSimpleName().equals(connectorAlias))
results.add(connector);