From 5919762009a0bbc4948bf881a6fbd885e30527b1 Mon Sep 17 00:00:00 2001 From: Chang-Chi Hsu Date: Sat, 20 Sep 2025 12:04:10 +0200 Subject: [PATCH] MINOR: Remove exitMessage.set() call in TopicBasedRemoteLogMetadataManagerTest (#20563) - **Reasons:** In this case, the `exit(int statusCode)` method invokes `exit(statusCode, null)`, which means the `message` argument is always `null` in this code path. As a result, assigning `exitMessage` has no effect and can be safely removed. - **Changes:** Remove a redundant field assignment. Reviewers: Chia-Ping Tsai --- .../storage/TopicBasedRemoteLogMetadataManagerTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java b/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java index c3a5beebad9..723e756036c 100644 --- a/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java +++ b/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java @@ -46,7 +46,6 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicInteger; -import java.util.concurrent.atomic.AtomicReference; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; @@ -344,13 +343,11 @@ public class TopicBasedRemoteLogMetadataManagerTest { // Set up a custom exit procedure for testing final AtomicBoolean exitCalled = new AtomicBoolean(false); final AtomicInteger exitCode = new AtomicInteger(-1); - final AtomicReference exitMessage = new AtomicReference<>(); // Set custom exit procedure that won't actually exit the process Exit.setExitProcedure((statusCode, message) -> { exitCalled.set(true); exitCode.set(statusCode); - exitMessage.set(message); }); try (TopicBasedRemoteLogMetadataManager rlmm = new TopicBasedRemoteLogMetadataManager()) {