root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

MINOR: Add validation in MockAdminClient for replication factor (#7712) 

Reviewer: Matthias J. Sax <matthias@confluent.io>
This commit is contained in:
Stanislav Kozlovski 2019-11-22 07:40:19 +00:00 committed by Matthias J. Sax
parent f9fc53ea28
commit 5d0c2f3b2a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java
View File

@ -175,6 +175,11 @@ public class MockAdminClient extends AdminClient {
continue;
}
int replicationFactor = newTopic.replicationFactor();
if (replicationFactor > brokers.size())
throw new IllegalArgumentException(
String.format("NewTopic %s cannot have a replication factor of %d that is larger than the number of brokers %s",
newTopic, replicationFactor, brokers));
List<Node> replicas = new ArrayList<>(replicationFactor);
for (int i = 0; i < replicationFactor; ++i) {
replicas.add(brokers.get(i));