root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

MINOR: Remove code of removed metric (#12453) 

When we removed metric skipped-records in 3.0 we missed to
remove some code related to that metric.

Reviewer: Guozhang Wang <wangguoz@gmail.com>
This commit is contained in:
Bruno Cadonna 2022-07-29 16:53:01 +02:00 committed by GitHub
parent 517e4d9278
commit 5f7c99dd77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetrics.java
View File

@ -45,7 +45,6 @@ public class ThreadMetrics {
private static final String PUNCTUATE = "punctuate"; private static final String PUNCTUATE = "punctuate";
private static final String CREATE_TASK = "task-created"; private static final String CREATE_TASK = "task-created";
private static final String CLOSE_TASK = "task-closed"; private static final String CLOSE_TASK = "task-closed";
private static final String SKIP_RECORD = "skipped-records";
private static final String BLOCKED_TIME = "blocked-time-ns-total"; private static final String BLOCKED_TIME = "blocked-time-ns-total";
private static final String THREAD_START_TIME = "thread-start-time"; private static final String THREAD_START_TIME = "thread-start-time";
@ -79,9 +78,6 @@ public class ThreadMetrics {
private static final String PUNCTUATE_RATE_DESCRIPTION = RATE_DESCRIPTION + PUNCTUATE_DESCRIPTION; private static final String PUNCTUATE_RATE_DESCRIPTION = RATE_DESCRIPTION + PUNCTUATE_DESCRIPTION;
private static final String PUNCTUATE_AVG_LATENCY_DESCRIPTION = "The average punctuate latency"; private static final String PUNCTUATE_AVG_LATENCY_DESCRIPTION = "The average punctuate latency";
private static final String PUNCTUATE_MAX_LATENCY_DESCRIPTION = "The maximum punctuate latency"; private static final String PUNCTUATE_MAX_LATENCY_DESCRIPTION = "The maximum punctuate latency";
private static final String SKIP_RECORDS_DESCRIPTION = "skipped records";
private static final String SKIP_RECORD_TOTAL_DESCRIPTION = TOTAL_DESCRIPTION + SKIP_RECORDS_DESCRIPTION;
private static final String SKIP_RECORD_RATE_DESCRIPTION = RATE_DESCRIPTION + SKIP_RECORDS_DESCRIPTION;
private static final String COMMIT_OVER_TASKS_DESCRIPTION = private static final String COMMIT_OVER_TASKS_DESCRIPTION =
"calls to commit over all tasks assigned to one stream thread"; "calls to commit over all tasks assigned to one stream thread";
private static final String COMMIT_OVER_TASKS_TOTAL_DESCRIPTION = TOTAL_DESCRIPTION + COMMIT_OVER_TASKS_DESCRIPTION; private static final String COMMIT_OVER_TASKS_TOTAL_DESCRIPTION = TOTAL_DESCRIPTION + COMMIT_OVER_TASKS_DESCRIPTION;
@ -123,18 +119,6 @@ public class ThreadMetrics {
); );
} }
public static Sensor skipRecordSensor(final String threadId,
final StreamsMetricsImpl streamsMetrics) {
return invocationRateAndCountSensor(
threadId,
SKIP_RECORD,
SKIP_RECORD_RATE_DESCRIPTION,
SKIP_RECORD_TOTAL_DESCRIPTION,
RecordingLevel.INFO,
streamsMetrics
);
}
public static Sensor commitSensor(final String threadId, public static Sensor commitSensor(final String threadId,
final StreamsMetricsImpl streamsMetrics) { final StreamsMetricsImpl streamsMetrics) {
return invocationRateAndCountAndAvgAndMaxLatencySensor( return invocationRateAndCountAndAvgAndMaxLatencySensor(

2
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
View File

@ -371,8 +371,6 @@ public class ThreadMetricsTest {
assertThat(sensor, is(expectedSensor)); assertThat(sensor, is(expectedSensor));
} }
} }
@Test
public void shouldGetCreateTaskSensor() { public void shouldGetCreateTaskSensor() {
final String operation = "task-created"; final String operation = "task-created";
final String totalDescription = "The total number of newly created tasks"; final String totalDescription = "The total number of newly created tasks";