root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-17469: Moved share external interfaces to share module. (#17262) 

Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>, David Arthur <mumrah@gmail.com>
This commit is contained in:
Sushant Mahajan 2024-09-24 21:38:01 +05:30 committed by GitHub
parent 1bd9dc3ffc
commit 67f966f348
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
40 changed files with 59 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
build.gradle
View File

@ -1637,6 +1637,7 @@ project(':share-coordinator') {
implementation project(':metadata')
implementation project(':server')
implementation project(':server-common')
implementation project(':share')
implementation libs.slf4jApi
implementation libs.metrics

2
checkstyle/import-control-share-coordinator.xml
View File

@ -56,7 +56,7 @@
<allow pkg="org.apache.kafka.metadata" />
<allow pkg="org.apache.kafka.server.common" />
<allow pkg="org.apache.kafka.server.config" />
<allow pkg="org.apache.kafka.server.group.share" />
<allow pkg="org.apache.kafka.server.share" />
<allow pkg="org.apache.kafka.server.record" />
<allow pkg="org.apache.kafka.server.util" />
<allow pkg="org.apache.kafka.server.util.timer" />

1
checkstyle/import-control-share.xml
View File

@ -33,6 +33,7 @@
<!-- anyone can use public classes -->
<allow pkg="org.apache.kafka.common" exact-match="true" />
<allow pkg="org.apache.kafka.common.utils" />
<allow pkg="org.apache.kafka.common.annotation" />
<!-- protocol, records and request/response utilities -->
<allow pkg="org.apache.kafka.common.message" />

22
core/src/main/java/kafka/server/share/SharePartition.java
View File

@ -32,18 +32,18 @@ import org.apache.kafka.common.message.ShareFetchResponseData.AcquiredRecords;
import org.apache.kafka.common.protocol.Errors;
import org.apache.kafka.common.record.RecordBatch;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.server.group.share.GroupTopicPartitionData;
import org.apache.kafka.server.group.share.PartitionAllData;
import org.apache.kafka.server.group.share.PartitionErrorData;
import org.apache.kafka.server.group.share.PartitionFactory;
import org.apache.kafka.server.group.share.PartitionIdLeaderEpochData;
import org.apache.kafka.server.group.share.PartitionStateBatchData;
import org.apache.kafka.server.group.share.Persister;
import org.apache.kafka.server.group.share.PersisterStateBatch;
import org.apache.kafka.server.group.share.ReadShareGroupStateParameters;
import org.apache.kafka.server.group.share.TopicData;
import org.apache.kafka.server.group.share.WriteShareGroupStateParameters;
import org.apache.kafka.server.share.GroupTopicPartitionData;
import org.apache.kafka.server.share.PartitionAllData;
import org.apache.kafka.server.share.PartitionErrorData;
import org.apache.kafka.server.share.PartitionFactory;
import org.apache.kafka.server.share.PartitionIdLeaderEpochData;
import org.apache.kafka.server.share.PartitionStateBatchData;
import org.apache.kafka.server.share.Persister;
import org.apache.kafka.server.share.PersisterStateBatch;
import org.apache.kafka.server.share.ReadShareGroupStateParameters;
import org.apache.kafka.server.share.ShareAcknowledgementBatch;
import org.apache.kafka.server.share.TopicData;
import org.apache.kafka.server.share.WriteShareGroupStateParameters;
import org.apache.kafka.server.util.timer.Timer;
import org.apache.kafka.server.util.timer.TimerTask;
import org.apache.kafka.storage.internals.log.FetchPartitionData;

2
core/src/main/java/kafka/server/share/SharePartitionManager.java
View File

@ -38,8 +38,8 @@ import org.apache.kafka.common.requests.ShareFetchRequest;
import org.apache.kafka.common.requests.ShareRequestMetadata;
import org.apache.kafka.common.utils.ImplicitLinkedHashCollection;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.server.group.share.Persister;
import org.apache.kafka.server.share.CachedSharePartition;
import org.apache.kafka.server.share.Persister;
import org.apache.kafka.server.share.ShareAcknowledgementBatch;
import org.apache.kafka.server.share.context.FinalContext;
import org.apache.kafka.server.share.context.ShareFetchContext;

2
core/src/main/scala/kafka/server/BrokerServer.scala
View File

@ -47,7 +47,7 @@ import org.apache.kafka.server.{AssignmentsManager, ClientMetricsManager, NodeTo
import org.apache.kafka.server.authorizer.Authorizer
import org.apache.kafka.server.common.{ApiMessageAndVersion, DirectoryEventHandler, TopicIdPartition}
import org.apache.kafka.server.config.ConfigType
import org.apache.kafka.server.group.share.{NoOpShareStatePersister, Persister}
import org.apache.kafka.server.share.{NoOpShareStatePersister, Persister}
import org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig
import org.apache.kafka.server.metrics.{ClientMetricsReceiverPlugin, KafkaYammerMetrics}
import org.apache.kafka.server.network.{EndpointReadyFutures, KafkaAuthorizerServerInfo}

4
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
View File

@ -49,10 +49,10 @@ import org.apache.kafka.common.requests.ShareRequestMetadata;
import org.apache.kafka.common.utils.ImplicitLinkedHashCollection;
import org.apache.kafka.common.utils.MockTime;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.server.group.share.NoOpShareStatePersister;
import org.apache.kafka.server.group.share.Persister;
import org.apache.kafka.server.share.CachedSharePartition;
import org.apache.kafka.server.share.ErroneousAndValidPartitionData;
import org.apache.kafka.server.share.NoOpShareStatePersister;
import org.apache.kafka.server.share.Persister;
import org.apache.kafka.server.share.ShareAcknowledgementBatch;
import org.apache.kafka.server.share.context.FinalContext;
import org.apache.kafka.server.share.context.ShareFetchContext;

14
core/src/test/java/kafka/server/share/SharePartitionTest.java
View File

@ -37,14 +37,14 @@ import org.apache.kafka.common.record.MemoryRecordsBuilder;
import org.apache.kafka.common.record.TimestampType;
import org.apache.kafka.common.utils.MockTime;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.server.group.share.NoOpShareStatePersister;
import org.apache.kafka.server.group.share.PartitionFactory;
import org.apache.kafka.server.group.share.Persister;
import org.apache.kafka.server.group.share.PersisterStateBatch;
import org.apache.kafka.server.group.share.ReadShareGroupStateResult;
import org.apache.kafka.server.group.share.TopicData;
import org.apache.kafka.server.group.share.WriteShareGroupStateResult;
import org.apache.kafka.server.share.NoOpShareStatePersister;
import org.apache.kafka.server.share.PartitionFactory;
import org.apache.kafka.server.share.Persister;
import org.apache.kafka.server.share.PersisterStateBatch;
import org.apache.kafka.server.share.ReadShareGroupStateResult;
import org.apache.kafka.server.share.ShareAcknowledgementBatch;
import org.apache.kafka.server.share.TopicData;
import org.apache.kafka.server.share.WriteShareGroupStateResult;
import org.apache.kafka.server.util.FutureUtils;
import org.apache.kafka.server.util.timer.SystemTimer;
import org.apache.kafka.server.util.timer.SystemTimerReaper;

2
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/PersisterOffsetsStateBatch.java
View File

@ -19,7 +19,7 @@ package org.apache.kafka.coordinator.share;
import org.apache.kafka.common.message.WriteShareGroupStateRequestData;
import org.apache.kafka.coordinator.share.generated.ShareUpdateValue;
import org.apache.kafka.server.group.share.PersisterStateBatch;
import org.apache.kafka.server.share.PersisterStateBatch;
import java.util.Objects;

2
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java
View File

@ -43,8 +43,8 @@ import org.apache.kafka.coordinator.common.runtime.MultiThreadedEventProcessor;
import org.apache.kafka.coordinator.common.runtime.PartitionWriter;
import org.apache.kafka.coordinator.share.metrics.ShareCoordinatorMetrics;
import org.apache.kafka.server.config.ShareCoordinatorConfig;
import org.apache.kafka.server.group.share.SharePartitionKey;
import org.apache.kafka.server.record.BrokerCompressionType;
import org.apache.kafka.server.share.SharePartitionKey;
import org.apache.kafka.server.util.timer.Timer;
import org.slf4j.Logger;

4
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java
View File

@ -47,8 +47,8 @@ import org.apache.kafka.image.MetadataDelta;
import org.apache.kafka.image.MetadataImage;
import org.apache.kafka.server.common.ApiMessageAndVersion;
import org.apache.kafka.server.config.ShareCoordinatorConfig;
import org.apache.kafka.server.group.share.PartitionFactory;
import org.apache.kafka.server.group.share.SharePartitionKey;
import org.apache.kafka.server.share.PartitionFactory;
import org.apache.kafka.server.share.SharePartitionKey;
import org.apache.kafka.timeline.SnapshotRegistry;
import org.apache.kafka.timeline.TimelineHashMap;

2
share-coordinator/src/test/java/org/apache/kafka/coordinator/share/ShareCoordinatorShardTest.java
View File

@ -40,7 +40,7 @@ import org.apache.kafka.image.TopicImage;
import org.apache.kafka.metadata.PartitionRegistration;
import org.apache.kafka.server.common.ApiMessageAndVersion;
import org.apache.kafka.server.config.ShareCoordinatorConfig;
import org.apache.kafka.server.group.share.SharePartitionKey;
import org.apache.kafka.server.share.SharePartitionKey;
import org.apache.kafka.timeline.SnapshotRegistry;
import org.junit.jupiter.api.Test;

2
server-common/src/main/java/org/apache/kafka/server/group/share/DeleteShareGroupStateParameters.java → share/src/main/java/org/apache/kafka/server/share/DeleteShareGroupStateParameters.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.DeleteShareGroupStateRequestData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/DeleteShareGroupStateResult.java → share/src/main/java/org/apache/kafka/server/share/DeleteShareGroupStateResult.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.DeleteShareGroupStateResponseData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/GroupTopicPartitionData.java → share/src/main/java/org/apache/kafka/server/share/GroupTopicPartitionData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import java.util.List;
import java.util.Objects;

2
server-common/src/main/java/org/apache/kafka/server/group/share/InitializeShareGroupStateParameters.java → share/src/main/java/org/apache/kafka/server/share/InitializeShareGroupStateParameters.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.InitializeShareGroupStateRequestData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/InitializeShareGroupStateResult.java → share/src/main/java/org/apache/kafka/server/share/InitializeShareGroupStateResult.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.InitializeShareGroupStateResponseData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/NoOpShareStatePersister.java → share/src/main/java/org/apache/kafka/server/share/NoOpShareStatePersister.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import java.util.ArrayList;
import java.util.Collections;

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionAllData.java → share/src/main/java/org/apache/kafka/server/share/PartitionAllData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import java.util.List;

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionData.java → share/src/main/java/org/apache/kafka/server/share/PartitionData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import java.util.List;
import java.util.Objects;

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionErrorData.java → share/src/main/java/org/apache/kafka/server/share/PartitionErrorData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* This interface is implemented by classes used to contain the data for a partition with error data

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionFactory.java → share/src/main/java/org/apache/kafka/server/share/PartitionFactory.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.protocol.Errors;

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionIdData.java → share/src/main/java/org/apache/kafka/server/share/PartitionIdData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* This interface is implemented by classes used to contain the data for a partition with its partition index

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionIdLeaderEpochData.java → share/src/main/java/org/apache/kafka/server/share/PartitionIdLeaderEpochData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* This interface is implemented by classes used to contain the data for a partition with its leader epoch

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionInfoData.java → share/src/main/java/org/apache/kafka/server/share/PartitionInfoData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* This interface is implemented by classes used to contain the data for a partition in the

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionStateBatchData.java → share/src/main/java/org/apache/kafka/server/share/PartitionStateBatchData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import java.util.List;

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionStateData.java → share/src/main/java/org/apache/kafka/server/share/PartitionStateData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* This interface is implemented by classes used to contain the data for a partition with the state epoch and

2
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionStateErrorData.java → share/src/main/java/org/apache/kafka/server/share/PartitionStateErrorData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* This interface is implemented by classes used to contain the data for a partition with state and error data

2
server-common/src/main/java/org/apache/kafka/server/group/share/Persister.java → share/src/main/java/org/apache/kafka/server/share/Persister.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.annotation.InterfaceStability;

2
server-common/src/main/java/org/apache/kafka/server/group/share/PersisterParameters.java → share/src/main/java/org/apache/kafka/server/share/PersisterParameters.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* Marker interface for parameter classes related to the {@link Persister} result classes.

2
server-common/src/main/java/org/apache/kafka/server/group/share/PersisterResult.java → share/src/main/java/org/apache/kafka/server/share/PersisterResult.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
/**
* Marker interface for result classes related to the {@link Persister} result classes.

2
server-common/src/main/java/org/apache/kafka/server/group/share/PersisterStateBatch.java → share/src/main/java/org/apache/kafka/server/share/PersisterStateBatch.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.ReadShareGroupStateResponseData;
import org.apache.kafka.common.message.WriteShareGroupStateRequestData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/ReadShareGroupStateParameters.java → share/src/main/java/org/apache/kafka/server/share/ReadShareGroupStateParameters.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.ReadShareGroupStateRequestData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/ReadShareGroupStateResult.java → share/src/main/java/org/apache/kafka/server/share/ReadShareGroupStateResult.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.ReadShareGroupStateResponseData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/ReadShareGroupStateSummaryParameters.java → share/src/main/java/org/apache/kafka/server/share/ReadShareGroupStateSummaryParameters.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.ReadShareGroupStateSummaryRequestData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/ReadShareGroupStateSummaryResult.java → share/src/main/java/org/apache/kafka/server/share/ReadShareGroupStateSummaryResult.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.ReadShareGroupStateSummaryResponseData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/SharePartitionKey.java → share/src/main/java/org/apache/kafka/server/share/SharePartitionKey.java
View File

@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.TopicIdPartition;
import org.apache.kafka.common.Uuid;

2
server-common/src/main/java/org/apache/kafka/server/group/share/TopicData.java → share/src/main/java/org/apache/kafka/server/share/TopicData.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.Uuid;

2
server-common/src/main/java/org/apache/kafka/server/group/share/WriteShareGroupStateParameters.java → share/src/main/java/org/apache/kafka/server/share/WriteShareGroupStateParameters.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.WriteShareGroupStateRequestData;

2
server-common/src/main/java/org/apache/kafka/server/group/share/WriteShareGroupStateResult.java → share/src/main/java/org/apache/kafka/server/share/WriteShareGroupStateResult.java
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
package org.apache.kafka.server.group.share;
package org.apache.kafka.server.share;
import org.apache.kafka.common.message.WriteShareGroupStateResponseData;