From 71540c03b86f55111ca7cc9b0f87724b40e0bda2 Mon Sep 17 00:00:00 2001 From: Geordie Date: Thu, 7 Jan 2021 16:46:07 +0800 Subject: [PATCH] KAFKA-10874: Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest (#9778) Reviewers: Chia-Ping Tsai , David Jacot --- .../unit/kafka/server/ClientQuotasRequestTest.scala | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala b/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala index b72f3b9121b..2da2a71aff4 100644 --- a/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala +++ b/core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala @@ -29,6 +29,8 @@ import org.junit.Test import java.util import java.util.concurrent.{ExecutionException, TimeUnit} +import kafka.utils.TestUtils + import scala.jdk.CollectionConverters._ class ClientQuotasRequestTest extends BaseRequestTest { @@ -212,7 +214,12 @@ class ClientQuotasRequestTest extends BaseRequestTest { InetAddress.getByName(unknownHost) else InetAddress.getByName(entityName) - assertEquals(expectedMatches(entity), servers.head.socketServer.connectionQuotas.connectionRateForIp(entityIp), 0.01) + var currentServerQuota = 0 + TestUtils.waitUntilTrue( + () => { + currentServerQuota = servers.head.socketServer.connectionQuotas.connectionRateForIp(entityIp) + Math.abs(expectedMatches(entity) - currentServerQuota) < 0.01 + }, s"Connection quota of $entity is not ${expectedMatches(entity)} but $currentServerQuota") } }