root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Log pending join members (#17219) 

I am still chasing KAFKA-17493. I was able to narrow it down to an issue with the pending join members. This patch logs them in order to help me troubleshooting it further. I will revert this change when the issue is root caused.

Reviewers: David Arthur <mumrah@gmail.com>
This commit is contained in:
David Jacot 2024-09-18 02:34:06 -05:00 committed by GitHub
parent 95b734d3c8
commit 74bebf6e3d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
View File

@ -4043,7 +4043,7 @@ public class GroupMetadataManager {
if (!group.hasAllMembersJoined()) { if (!group.hasAllMembersJoined()) {
log.debug("Cannot complete join phase of group {} because not all the members have rejoined. " + log.debug("Cannot complete join phase of group {} because not all the members have rejoined. " +
"Members={}, AwaitingJoinResponses={}, PendingJoinMembers={}.", "Members={}, AwaitingJoinResponses={}, PendingJoinMembers={}.",
group.groupId(), group.numMembers(), group.numAwaitingJoinResponse(), group.numPendingJoinMembers()); group.groupId(), group.numMembers(), group.numAwaitingJoinResponse(), String.join(",", group.pendingJoinMembers()));
return EMPTY_RESULT; return EMPTY_RESULT;
} }

7
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
View File

@ -609,6 +609,13 @@ public class ClassicGroup implements Group {
return pendingJoinMembers.contains(memberId); return pendingJoinMembers.contains(memberId);
} }
/**
* @return The set of pending join members.
*/
public Set<String> pendingJoinMembers() {
return Collections.unmodifiableSet(pendingJoinMembers);
}
/** /**
* Add a pending member. * Add a pending member.
* *