root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Change the ProducerConfig constructor with `doLog` parameter to protected 

In applications that construct the various client configs multiple times, the config logging can be pretty extreme, so it's nice to be able to disable this for subsequent config objects that are created. We don't expose the constructors that accept a `doLog` parameter in the public API, but all the other clients at least make this constructor `protected` so it's possible to extend the class and suppress the excessive logging. However the ProducerConfig is the one case where this constructor is package-private. It would be nice to align it with the other client config classes and make this `protected` to allow turning off logging
This commit is contained in:
A. Sophie Blee-Goldman 2023-10-31 15:18:44 -07:00 committed by GitHub
parent ed3fa83d38
commit 7702f44c6e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
View File

@ -618,7 +618,7 @@ public class ProducerConfig extends AbstractConfig {
super(CONFIG, props);
}
ProducerConfig(Map<?, ?> props, boolean doLog) {
protected ProducerConfig(Map<?, ?> props, boolean doLog) {
super(CONFIG, props, doLog);
}