From 786d2c9975c7715b4f9959c2d2d40cde66e08e65 Mon Sep 17 00:00:00 2001 From: Ken Huang Date: Thu, 8 Aug 2024 08:53:15 +0800 Subject: [PATCH] KAFKA-17276; replicaDirectoryId for Fetch and FetchSnapshot should be ignorable (#16819) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The replicaDirectoryId field for FetchRequest and FetchSnapshotRequest should be ignorable. This allows data objects with the directory id to be serialized to any version of the requests. Reviewers: José Armando García Sancio , Chia-Ping Tsai --- clients/src/main/resources/common/message/FetchRequest.json | 2 +- .../src/main/resources/common/message/FetchSnapshotRequest.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/src/main/resources/common/message/FetchRequest.json b/clients/src/main/resources/common/message/FetchRequest.json index 228e9e4ff28..f92ccefb8dc 100644 --- a/clients/src/main/resources/common/message/FetchRequest.json +++ b/clients/src/main/resources/common/message/FetchRequest.json @@ -103,7 +103,7 @@ "about": "The earliest available offset of the follower replica. The field is only used when the request is sent by the follower."}, { "name": "PartitionMaxBytes", "type": "int32", "versions": "0+", "about": "The maximum bytes to fetch from this partition. See KIP-74 for cases where this limit may not be honored." }, - { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "17+", "taggedVersions": "17+", "tag": 0, + { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "17+", "taggedVersions": "17+", "tag": 0, "ignorable": true, "about": "The directory id of the follower fetching" } ]} ]}, diff --git a/clients/src/main/resources/common/message/FetchSnapshotRequest.json b/clients/src/main/resources/common/message/FetchSnapshotRequest.json index 9d50722d935..c43eeb4ce09 100644 --- a/clients/src/main/resources/common/message/FetchSnapshotRequest.json +++ b/clients/src/main/resources/common/message/FetchSnapshotRequest.json @@ -46,7 +46,7 @@ }, { "name": "Position", "type": "int64", "versions": "0+", "about": "The byte position within the snapshot to start fetching from" }, - { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "1+", "taggedVersions": "1+", "tag": 0, + { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "1+", "taggedVersions": "1+", "tag": 0, "ignorable": true, "about": "The directory id of the follower fetching" } ] }