root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

MINOR; Add kraft controller log level in log4j prop (#12707) 

Add KRaft controller log level entry in log4j.properties, otherwise, the controller.log is empty in KRaft mode.

Reviewers: José Armando García Sancio <jsancio@apache.org>, Ismael Juma <ismael@juma.me.uk>
This commit is contained in:
Luke Chen 2022-10-15 02:27:31 +08:00 committed by GitHub
parent f1e0fa91ab
commit 78b4ba7d85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
config/log4j.properties
View File

@ -76,6 +76,11 @@ log4j.additivity.kafka.request.logger=false
log4j.logger.kafka.network.RequestChannel$=WARN, requestAppender log4j.logger.kafka.network.RequestChannel$=WARN, requestAppender
log4j.additivity.kafka.network.RequestChannel$=false log4j.additivity.kafka.network.RequestChannel$=false
# Change the line below to adjust KRaft mode controller logging
log4j.logger.org.apache.kafka.controller=INFO, controllerAppender
log4j.additivity.org.apache.kafka.controller=false
# Change the line below to adjust ZK mode controller logging
log4j.logger.kafka.controller=TRACE, controllerAppender log4j.logger.kafka.controller=TRACE, controllerAppender
log4j.additivity.kafka.controller=false log4j.additivity.kafka.controller=false

2
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
View File

@ -370,7 +370,7 @@ class BrokerToControllerRequestThread(
debug("Controller isn't cached, looking for local metadata changes") debug("Controller isn't cached, looking for local metadata changes")
controllerNodeProvider.get() match { controllerNodeProvider.get() match {
case Some(controllerNode) => case Some(controllerNode) =>
info(s"Recorded new controller, from now on will use broker $controllerNode") info(s"Recorded new controller, from now on will use node $controllerNode")
updateControllerAddress(controllerNode) updateControllerAddress(controllerNode)
metadataUpdater.setNodes(Seq(controllerNode).asJava) metadataUpdater.setNodes(Seq(controllerNode).asJava)
case None => case None =>

2
core/src/main/scala/kafka/server/KafkaRaftServer.scala
View File

@ -47,8 +47,6 @@ import scala.jdk.CollectionConverters._
* constructing the controller and/or broker based on the `process.roles` * constructing the controller and/or broker based on the `process.roles`
* configuration and for managing their basic lifecycle (startup and shutdown). * configuration and for managing their basic lifecycle (startup and shutdown).
* *
* Note that this server is a work in progress and we are releasing it as
* early access in 2.8.0.
*/ */
class KafkaRaftServer( class KafkaRaftServer(
config: KafkaConfig, config: KafkaConfig,