root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: rename `resendBrokerRegistrationUnlessZkMode` to `resendBrokerRegistration` (#18645) 

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
Ken Huang 2025-01-24 00:33:05 +08:00 committed by GitHub
parent 400ecab518
commit 7e46087570
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
View File

@ -260,11 +260,11 @@ class BrokerLifecycleManager(
new OfflineDirBrokerFailureEvent(directory)) new OfflineDirBrokerFailureEvent(directory))
} }
def resendBrokerRegistrationUnlessZkMode(): Unit = { def resendBrokerRegistration(): Unit = {
eventQueue.append(new ResendBrokerRegistrationUnlessZkModeEvent()) eventQueue.append(new ResendBrokerRegistrationEvent())
} }
private class ResendBrokerRegistrationUnlessZkModeEvent extends EventQueue.Event { private class ResendBrokerRegistrationEvent extends EventQueue.Event {
override def run(): Unit = { override def run(): Unit = {
registered = false registered = false
scheduleNextCommunicationImmediately() scheduleNextCommunicationImmediately()

2
core/src/main/scala/kafka/server/BrokerServer.scala
View File

@ -534,7 +534,7 @@ class BrokerServer(
}) })
metadataPublishers.add(brokerMetadataPublisher) metadataPublishers.add(brokerMetadataPublisher)
brokerRegistrationTracker = new BrokerRegistrationTracker(config.brokerId, brokerRegistrationTracker = new BrokerRegistrationTracker(config.brokerId,
() => lifecycleManager.resendBrokerRegistrationUnlessZkMode()) () => lifecycleManager.resendBrokerRegistration())
metadataPublishers.add(brokerRegistrationTracker) metadataPublishers.add(brokerRegistrationTracker)

2
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala
View File

@ -288,7 +288,7 @@ class BrokerLifecycleManagerTest {
assertEquals(1000L, manager.brokerEpoch) assertEquals(1000L, manager.brokerEpoch)
// Trigger JBOD MV update // Trigger JBOD MV update
manager.resendBrokerRegistrationUnlessZkMode() manager.resendBrokerRegistration()
// Accept new registration, response sets epoch to 1200 // Accept new registration, response sets epoch to 1200
nextRegistrationRequest(1200L) nextRegistrationRequest(1200L)