root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: changed the default value of metadata_quorum in test methods to quorum.isolated_kraft where quorum.zk was used (#19707) 

There were some tests in share_consumer_test, where the default value of
metadata_quorum was quorum.zk. That is change to quorum.isolated_kraft in
this PR

Reviewers: Andrew Schofield <aschofield@confluent.io>
This commit is contained in:
Chirag Wadhwa 2025-05-14 13:52:43 +05:30 committed by GitHub
parent 692c7f14d6
commit 89cbafeec1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/kafkatest/tests/client/share_consumer_test.py
View File

@ -248,7 +248,7 @@ class ShareConsumerTest(VerifiableShareConsumerTest):
metadata_quorum=[quorum.isolated_kraft, quorum.combined_kraft], metadata_quorum=[quorum.isolated_kraft, quorum.combined_kraft],
use_share_groups=[True] use_share_groups=[True]
) )
def test_share_consumer_bounce(self, clean_shutdown, bounce_mode, metadata_quorum=quorum.zk, use_share_groups=True): def test_share_consumer_bounce(self, clean_shutdown, bounce_mode, metadata_quorum=quorum.isolated_kraft, use_share_groups=True):
""" """
Verify correct share consumer behavior when the share consumers in the group are consecutively restarted. Verify correct share consumer behavior when the share consumers in the group are consecutively restarted.
@ -290,7 +290,7 @@ class ShareConsumerTest(VerifiableShareConsumerTest):
metadata_quorum=[quorum.isolated_kraft, quorum.combined_kraft], metadata_quorum=[quorum.isolated_kraft, quorum.combined_kraft],
use_share_groups=[True] use_share_groups=[True]
) )
def test_share_consumer_failure(self, clean_shutdown, metadata_quorum=quorum.zk, num_failed_consumers=1, use_share_groups=True): def test_share_consumer_failure(self, clean_shutdown, metadata_quorum=quorum.isolated_kraft, num_failed_consumers=1, use_share_groups=True):
producer = self.setup_producer(self.TOPIC2["name"]) producer = self.setup_producer(self.TOPIC2["name"])
consumer = self.setup_share_group(self.TOPIC2["name"], offset_reset_strategy="earliest") consumer = self.setup_share_group(self.TOPIC2["name"], offset_reset_strategy="earliest")