root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 5 Packages Projects Releases Wiki Activity

MINOR: add a test for Protocol (#20169)
CI / build (push) Waiting to run Details 

see https://github.com/apache/kafka/pull/19769#issuecomment-3065869429
This patch adds a test to `ProtocolTest` to ensure the Protocol page displays the correct API version range.

Reviewers: Yung <yungyung7654321@gmail.com>, TengYao Chi
<frankvicky@apache.org>, Gaurav Narula <gaurav_narula2@apple.com>, Ken
Huang <s7133700@gmail.com>, Jimmy Wang <wangzhiwang@qq.com>
This commit is contained in:
Lan Ding 2025-07-19 19:31:25 +08:00 committed by GitHub
parent 1b351ad6e2
commit 908049fccc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clients/src/test/java/org/apache/kafka/common/protocol/ProtocolTest.java
View File

@ -19,6 +19,7 @@ package org.apache.kafka.common.protocol;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class ProtocolTest {
@ -27,6 +28,18 @@ public class ProtocolTest {
var html = Protocol.toHtml();
assertFalse(html.isBlank());
assertFalse(html.contains("LeaderAndIsr"), "Removed LeaderAndIsr should not show in HTML");
String requestVersion;
String responseVersion;
for (ApiKeys key : ApiKeys.clientApis()) {
for (short version = key.oldestVersion(); version <= key.latestVersion(); version++) {
requestVersion = key.name + " Request (Version: " + version;
responseVersion = key.name + " Response (Version: " + version;
assertTrue(html.contains(requestVersion), "Missing request header for " + key.name + " version:" + version);
assertTrue(html.contains(responseVersion), "Missing response header for " + key.name + " version:" + version);
}
}
}
}