From 9823d6781cb9d6a13b234723df85379a991a31b8 Mon Sep 17 00:00:00 2001 From: Luke Chen Date: Tue, 6 May 2025 09:42:52 +0900 Subject: [PATCH] MINOR: exclude error_prone_annotations lib from caffeine dependency (#19638) In https://github.com/apache/kafka/pull/16578 , we tried to exclude both `checker-qual` and `error_prone_annotations`, but when excluding `error_prone_annotations`, the compilation failed. So in the end, we only excluded `checker-qual` and shipped `error_prone_annotations.jar` to users. In Kafka v4.0.0, thanks to jdk 8 removal, we upgraded caffeine to the latest v3.1.8, instead of v2.x.x, and now, we can successfully pass the compilation without error after excluding `error_prone_annotations` from `caffeine`. Reviewers: Chia-Ping Tsai , Ken Huang --- LICENSE-binary | 1 - build.gradle | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE-binary b/LICENSE-binary index 6175d3ed7d4..7a35e39889e 100644 --- a/LICENSE-binary +++ b/LICENSE-binary @@ -212,7 +212,6 @@ License Version 2.0: - commons-lang3-3.12.0 - commons-logging-1.3.2 - commons-validator-1.9.0 -- error_prone_annotations-2.21.1 - jackson-annotations-2.16.2 - jackson-core-2.16.2 - jackson-databind-2.16.2 diff --git a/build.gradle b/build.gradle index 76a65157816..ceaa34a7815 100644 --- a/build.gradle +++ b/build.gradle @@ -2233,6 +2233,7 @@ project(':storage') { implementation project(':clients') implementation(libs.caffeine) { exclude group: 'org.checkerframework', module: 'checker-qual' + exclude group: 'com.google.errorprone', module: 'error_prone_annotations' } implementation libs.slf4jApi implementation libs.jacksonDatabind