root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-892 Change request log to include request completion not handling; reviewed by Joel Koshy

This commit is contained in:
Neha Narkhede 2013-04-30 17:20:54 -07:00
parent cae19aa44f
commit 988d4d8e65
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/scala/kafka/network/RequestChannel.scala
View File

@ -26,6 +26,7 @@ import kafka.common.TopicAndPartition
import kafka.utils.{Logging, SystemTime}
import kafka.message.ByteBufferMessageSet
import java.net._
import org.apache.log4j.Logger
object RequestChannel extends Logging {
@ -47,6 +48,7 @@ object RequestChannel extends Logging {
val requestId = buffer.getShort()
val requestObj: RequestOrResponse = RequestKeys.deserializerForKey(requestId)(buffer)
buffer = null
private val requestLogger = Logger.getLogger("kafka.request.logger")
trace("Received request : %s".format(requestObj))
def updateRequestMetrics() {
@ -76,8 +78,9 @@ object RequestChannel extends Logging {
m.responseSendTimeHist.update(responseSendTime)
m.totalTimeHist.update(totalTime)
}
trace("Completed request : %s, totalTime:%d, queueTime:%d, localTime:%d, remoteTime:%d, sendTime:%d"
.format(requestObj, totalTime, queueTime, apiLocalTime, apiRemoteTime, responseSendTime))
if(requestLogger.isTraceEnabled)
requestLogger.trace("Completed request:%s from client %s;totalTime:%d,queueTime:%d,localTime:%d,remoteTime:%d,sendTime:%d"
.format(requestObj, remoteAddress, totalTime, queueTime, apiLocalTime, apiRemoteTime, responseSendTime))
}
}

4
core/src/main/scala/kafka/server/KafkaApis.scala
View File

@ -46,7 +46,6 @@ class KafkaApis(val requestChannel: RequestChannel,
new FetchRequestPurgatory(requestChannel, replicaManager.config.fetchPurgatoryPurgeIntervalRequests)
private val delayedRequestMetrics = new DelayedRequestMetrics
private val requestLogger = Logger.getLogger("kafka.request.logger")
this.logIdent = "[KafkaApi-%d] ".format(brokerId)
/**
@ -54,8 +53,7 @@ class KafkaApis(val requestChannel: RequestChannel,
*/
def handle(request: RequestChannel.Request) {
try{
if(requestLogger.isTraceEnabled)
requestLogger.trace("Handling request: " + request.requestObj + " from client: " + request.remoteAddress)
trace("Handling request: " + request.requestObj + " from client: " + request.remoteAddress)
request.requestId match {
case RequestKeys.ProduceKey => handleProducerRequest(request)
case RequestKeys.FetchKey => handleFetchRequest(request)