diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java index 6f1f8c8bc64..1ca42dbc75c 100644 --- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java +++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java @@ -1899,7 +1899,7 @@ public class AsyncKafkaConsumer implements ConsumerDelegate { private void sendFetches(Timer timer) { try { applicationEventHandler.addAndGet(new CreateFetchRequestsEvent(calculateDeadlineMs(timer))); - } catch (TimeoutException e) { + } catch (TimeoutException swallow) { // Can be ignored, per above comments. } } @@ -2212,7 +2212,7 @@ public class AsyncKafkaConsumer implements ConsumerDelegate { Timer pollInterval = time.timer(100L); return ConsumerUtils.getResult(future, pollInterval); } - } catch (TimeoutException e) { + } catch (TimeoutException swallow) { // Ignore this as we will retry the event until the timeout expires. } finally { timer.update(); diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java index 4c504970ef7..c497dd63e04 100644 --- a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java @@ -1977,7 +1977,7 @@ public class KafkaConsumerTest { try { newConsumer(groupProtocol, null, Optional.of(Boolean.TRUE)); fail("Expected an InvalidConfigurationException"); - } catch (InvalidConfigurationException e) { + } catch (InvalidConfigurationException swallow) { // OK, expected } @@ -2142,7 +2142,7 @@ public class KafkaConsumerTest { future.get(100, TimeUnit.MILLISECONDS); if (closeTimeoutMs != 0) fail("Close completed without waiting for commit or leave response"); - } catch (TimeoutException e) { + } catch (TimeoutException swallow) { // Expected exception } diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java index 513ad3fe294..16e4c9d4b3f 100644 --- a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java @@ -182,8 +182,8 @@ public class AsyncKafkaConsumerTest { if (consumer != null) { try { consumer.close(CloseOptions.timeout(Duration.ZERO)); - } catch (Exception e) { - // best effort to clean up after each test, but may throw (ex. if callbacks where + } catch (Exception swallow) { + // best effort to clean up after each test, but may throw (ex. if callbacks were // throwing errors) } }