root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-17253: Deprecate Leaking Getter Methods in Joined Helper Class (#17164) 

Reviewers: Matthias J. Sax <matthias@confluent.io>
This commit is contained in:
TengYao Chi 2024-09-13 01:13:22 +08:00 committed by GitHub
parent 2703b64c4c
commit 9b53b525e8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java
View File

@ -271,18 +271,35 @@ public class Joined<K, VLeft, VRight> implements NamedOperation<Joined<K, VLeft,
return new Joined<>(keySerde, leftValueSerde, rightValueSerde, name, gracePeriod); return new Joined<>(keySerde, leftValueSerde, rightValueSerde, name, gracePeriod);
} }
/**
* @deprecated since 4.0 and should not be used any longer.
*/
@Deprecated
public Duration gracePeriod() { public Duration gracePeriod() {
return gracePeriod; return gracePeriod;
} }
/**
* @deprecated since 4.0 and should not be used any longer.
*/
@Deprecated
public Serde<K> keySerde() { public Serde<K> keySerde() {
return keySerde; return keySerde;
} }
/**
* @deprecated since 4.0 and should not be used any longer.
*/
@Deprecated
public Serde<VLeft> valueSerde() { public Serde<VLeft> valueSerde() {
return leftValueSerde; return leftValueSerde;
} }
/**
* @deprecated since 4.0 and should not be used any longer.
*/
@Deprecated
public Serde<VRight> otherValueSerde() { public Serde<VRight> otherValueSerde() {
return rightValueSerde; return rightValueSerde;
} }

2
streams/src/main/java/org/apache/kafka/streams/kstream/internals/JoinedInternal.java
View File

@ -27,10 +27,12 @@ public class JoinedInternal<K, VLeft, VRight> extends Joined<K, VLeft, VRight>
super(joined); super(joined);
} }
@SuppressWarnings("deprecation")
public Duration gracePeriod() { public Duration gracePeriod() {
return gracePeriod; return gracePeriod;
} }
@SuppressWarnings("deprecation")
public Serde<K> keySerde() { public Serde<K> keySerde() {
return keySerde; return keySerde;
} }