From 9ba262162062ecb4d0fd81b439dd51a2195f6bcf Mon Sep 17 00:00:00 2001 From: Jhen-Yung Hsu Date: Mon, 3 Feb 2025 20:06:01 +0800 Subject: [PATCH] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient (#18775) Reviewers: Ismael Juma , Ken Huang , Chia-Ping Tsai --- .../scala/unit/kafka/metrics/MetricsTest.scala | 17 ----------------- docs/zk2kraft.html | 7 +++++++ 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/core/src/test/scala/unit/kafka/metrics/MetricsTest.scala b/core/src/test/scala/unit/kafka/metrics/MetricsTest.scala index b1bc03b6ff4..5c795a0e68f 100644 --- a/core/src/test/scala/unit/kafka/metrics/MetricsTest.scala +++ b/core/src/test/scala/unit/kafka/metrics/MetricsTest.scala @@ -234,23 +234,6 @@ class MetricsTest extends KafkaServerTestHarness with Logging { }) } - /** - * Test that the metrics are created with the right name, testZooKeeperStateChangeRateMetrics - * and testZooKeeperSessionStateMetric in ZooKeeperClientTest test the metrics behaviour. - */ - @ParameterizedTest - @ValueSource(strings = Array("kraft")) - def testSessionExpireListenerMetrics(quorum: String): Unit = { - val metrics = KafkaYammerMetrics.defaultRegistry.allMetrics - val expectedNumMetrics = 0 - assertEquals(expectedNumMetrics, metrics.keySet.asScala. - count(_.getMBeanName == "kafka.server:type=SessionExpireListener,name=SessionState")) - assertEquals(expectedNumMetrics, metrics.keySet.asScala. - count(_.getMBeanName == "kafka.server:type=SessionExpireListener,name=ZooKeeperExpiresPerSec")) - assertEquals(expectedNumMetrics, metrics.keySet.asScala. - count(_.getMBeanName == "kafka.server:type=SessionExpireListener,name=ZooKeeperDisconnectsPerSec")) - } - private def topicMetrics(topic: Option[String]): Set[String] = { val metricNames = KafkaYammerMetrics.defaultRegistry.allMetrics().keySet.asScala.map(_.getMBeanName) filterByTopicMetricRegex(metricNames, topic) diff --git a/docs/zk2kraft.html b/docs/zk2kraft.html index c94949dff12..f2c2153b6dd 100644 --- a/docs/zk2kraft.html +++ b/docs/zk2kraft.html @@ -198,6 +198,13 @@
  • kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic
  • kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=ElectLeader
  • kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=topic
    • +
  • kafka.server:type=SessionExpireListener,name=SessionState
    • +
  • kafka.server:type=SessionExpireListener,name=ZooKeeperAuthFailuresPerSec
    • +
  • kafka.server:type=SessionExpireListener,name=ZooKeeperDisconnectsPerSec
    • +
  • kafka.server:type=SessionExpireListener,name=ZooKeeperExpiresPerSec
    • +
  • kafka.server:type=SessionExpireListener,name=ZooKeeperReadOnlyConnectsPerSec
    • +
  • kafka.server:type=SessionExpireListener,name=ZooKeeperSaslAuthenticationsPerSec
    • +
  • kafka.server:type=SessionExpireListener,name=ZooKeeperSyncConnectsPerSec
  • kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs