From 9daf9cdb0f83a62b55dd21a0895c803fc47bddd0 Mon Sep 17 00:00:00 2001 From: Shashank Hosahalli Shivamurthy Date: Tue, 16 Sep 2025 16:55:20 -0700 Subject: [PATCH] cleanup unnecessary comments --- .../processor/internals/TaskManagerTest.java | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java index 82413a14046..419930a5987 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java @@ -4215,39 +4215,30 @@ public class TaskManagerTest { @Test public void shouldPunctuateActiveTasks() { - // Create a StreamTask using the builder pattern for StateUpdater compatibility + final StreamTask task00 = statefulTask(taskId00, taskId00ChangelogPartitions) .withInputPartitions(taskId00Partitions) - .inState(State.RUNNING) // Task has completed restoration and is RUNNING + .inState(State.RUNNING) .build(); - // Mock punctuation methods to return true (indicating punctuation occurred) when(task00.maybePunctuateStreamTime()).thenReturn(true); when(task00.maybePunctuateSystemTime()).thenReturn(true); - // Mock TasksRegistry to include the running task as an active task final TasksRegistry tasks = mock(TasksRegistry.class); when(tasks.activeTasks()).thenReturn(Set.of(task00)); - // Mock StateUpdater to indicate no tasks are currently being restored - // This simulates that all restoration has completed when(stateUpdater.restoresActiveTasks()).thenReturn(false); when(stateUpdater.hasExceptionsAndFailedTasks()).thenReturn(false); when(stateUpdater.drainRestoredActiveTasks(any(Duration.class))).thenReturn(Set.of()); when(stateUpdater.drainExceptionsAndFailedTasks()).thenReturn(List.of()); - // Set up TaskManager with StateUpdater enabled final TaskManager taskManager = setUpTaskManager(ProcessingMode.AT_LEAST_ONCE, tasks, false); - // Call checkStateUpdater to ensure coordination with StateUpdater is done - // This simulates the normal flow where StreamThread calls checkStateUpdater assertTrue(taskManager.checkStateUpdater(time.milliseconds(), noOpResetter)); - // Verify punctuation calls both stream and system time punctuators // one for stream and one for system time assertThat(taskManager.punctuate(), equalTo(2)); - // Verify that both punctuation methods were called verify(task00).maybePunctuateStreamTime(); verify(task00).maybePunctuateSystemTime(); }