root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: printing share group describe result in sorted order (#19599) 

This PR sorts the information that is printed when kafka-share-groups.sh
--describe is used

Reviewers: Andrew Schofield <aschofield@confluent.io>
This commit is contained in:
Chirag Wadhwa 2025-05-01 20:11:41 +05:30 committed by GitHub
parent 8dbf56e4b5
commit 9e7e9a8ff6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java
View File

@ -44,6 +44,7 @@ import java.util.AbstractMap.SimpleImmutableEntry;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.Comparator;
import java.util.HashMap; import java.util.HashMap;
import java.util.HashSet; import java.util.HashSet;
import java.util.LinkedHashSet; import java.util.LinkedHashSet;
@ -426,7 +427,12 @@ public class ShareGroupCommand {
private void printOffsets(TreeMap<String, Entry<ShareGroupDescription, Collection<SharePartitionOffsetInformation>>> offsets, boolean verbose) { private void printOffsets(TreeMap<String, Entry<ShareGroupDescription, Collection<SharePartitionOffsetInformation>>> offsets, boolean verbose) {
offsets.forEach((groupId, tuple) -> { offsets.forEach((groupId, tuple) -> {
Collection<SharePartitionOffsetInformation> offsetsInfo = tuple.getValue(); Collection<SharePartitionOffsetInformation> offsetsInfo = tuple.getValue().stream()
.sorted(Comparator
.comparing((SharePartitionOffsetInformation info) -> info.topic)
.thenComparingInt(info -> info.partition))
.toList();
String fmt = printOffsetFormat(groupId, offsetsInfo, verbose); String fmt = printOffsetFormat(groupId, offsetsInfo, verbose);
if (verbose) { if (verbose) {
@ -496,7 +502,10 @@ public class ShareGroupCommand {
descriptions.forEach((groupId, description) -> { descriptions.forEach((groupId, description) -> {
int groupLen = Math.max(15, groupId.length()); int groupLen = Math.max(15, groupId.length());
int maxConsumerIdLen = 15, maxHostLen = 15, maxClientIdLen = 15; int maxConsumerIdLen = 15, maxHostLen = 15, maxClientIdLen = 15;
Collection<ShareMemberDescription> members = description.members(); Collection<ShareMemberDescription> members = description.members()
.stream()
.sorted(Comparator.comparing(ShareMemberDescription::consumerId))
.toList();
if (maybePrintEmptyGroupState(groupId, description.groupState(), description.members().size())) { if (maybePrintEmptyGroupState(groupId, description.groupState(), description.members().size())) {
for (ShareMemberDescription member : members) { for (ShareMemberDescription member : members) {
maxConsumerIdLen = Math.max(maxConsumerIdLen, member.consumerId().length()); maxConsumerIdLen = Math.max(maxConsumerIdLen, member.consumerId().length());