From a83bfda39bbec46b134f5ab8093e590665a282a0 Mon Sep 17 00:00:00 2001
From: Chuckame <Chuckame@users.noreply.github.com>
Date: Sun, 15 Jun 2025 18:18:29 +0200
Subject: [PATCH] MINOR: Fix typo to actually use rocksdb
 setOptimizeFiltersForHits (#19837)

This PR fixes a typo in the `RocksDBStore` where it currently uses a
getter named `optimizeFiltersForHits`. However, to set the flag to true,
we have to use `setOptimizeFiltersForHits(true)` instead.

Reviewers: Matthias J. Sax <matthias@confluent.io>, Chia-Ping Tsai
 <chia7712@gmail.com>
---
 .../org/apache/kafka/streams/state/internals/RocksDBStore.java  | 2 +-
 .../apache/kafka/streams/state/internals/RocksDBStoreTest.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
index 6457a2c8fab..ede618237cf 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
@@ -195,7 +195,7 @@ public class RocksDBStore implements KeyValueStore<Bytes, byte[]>, BatchWritingS
         filter = new BloomFilter();
         tableConfig.setFilterPolicy(filter);
 
-        userSpecifiedOptions.optimizeFiltersForHits();
+        userSpecifiedOptions.setOptimizeFiltersForHits(true);
         userSpecifiedOptions.setTableFormatConfig(tableConfig);
         userSpecifiedOptions.setWriteBufferSize(WRITE_BUFFER_SIZE);
         userSpecifiedOptions.setCompressionType(COMPRESSION_TYPE);
diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
index 8a02289890e..70224c8013c 100644
--- a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
@@ -1256,7 +1256,7 @@ public class RocksDBStoreTest extends AbstractKeyValueStoreTest {
             if (enableBloomFilters) {
                 filter = new BloomFilter();
                 tableConfig.setFilterPolicy(filter);
-                options.optimizeFiltersForHits();
+                options.setOptimizeFiltersForHits(true);
                 bloomFiltersSet = true;
             } else {
                 options.setOptimizeFiltersForHits(false);