root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-18486 Remove ReplicaManager#becomeLeaderOrFollower in `testVerificationErrorConversions` (#19923) 

Remove ReplicaManager#becomeLeaderOrFollower in
`testVerificationErrorConversionsTV1 ` and
`testVerificationErrorConversionsTV2 `.

Reviewers: Ken Huang <s7133700@gmail.com>, TengYao Chi
<kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
Nick Guo 2025-06-11 18:47:23 +08:00 committed by GitHub
parent 2e968560e0
commit ab42f00bbe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
View File

@ -2649,6 +2649,7 @@ class ReplicaManagerTest {
) )
) )
def testVerificationErrorConversionsTV2(error: Errors): Unit = { def testVerificationErrorConversionsTV2(error: Errors): Unit = {
val localId = 1
val tp0 = new TopicPartition(topic, 0) val tp0 = new TopicPartition(topic, 0)
val producerId = 24L val producerId = 24L
val producerEpoch = 0.toShort val producerEpoch = 0.toShort
@ -2657,9 +2658,8 @@ class ReplicaManagerTest {
val replicaManager = setUpReplicaManagerWithMockedAddPartitionsToTxnManager(addPartitionsToTxnManager, List(tp0)) val replicaManager = setUpReplicaManagerWithMockedAddPartitionsToTxnManager(addPartitionsToTxnManager, List(tp0))
try { try {
replicaManager.becomeLeaderOrFollower(1, val leaderDelta = topicsCreateDelta(localId, isStartIdLeader = true, partitions = List(0, 1), List.empty, topic, topicIds(topic))
makeLeaderAndIsrRequest(topicIds(tp0.topic), tp0, Seq(0, 1), new LeaderAndIsr(1, List(0, 1).map(Int.box).asJava)), replicaManager.applyDelta(leaderDelta, imageFromTopics(leaderDelta.apply()))
(_, _) => ())
val transactionalRecords = MemoryRecords.withTransactionalRecords(Compression.NONE, producerId, producerEpoch, sequence, val transactionalRecords = MemoryRecords.withTransactionalRecords(Compression.NONE, producerId, producerEpoch, sequence,
new SimpleRecord("message".getBytes)) new SimpleRecord("message".getBytes))
@ -2699,6 +2699,7 @@ class ReplicaManagerTest {
) )
) )
def testVerificationErrorConversionsTV1(error: Errors): Unit = { def testVerificationErrorConversionsTV1(error: Errors): Unit = {
val localId = 1
val tp0 = new TopicPartition(topic, 0) val tp0 = new TopicPartition(topic, 0)
val producerId = 24L val producerId = 24L
val producerEpoch = 0.toShort val producerEpoch = 0.toShort
@ -2707,9 +2708,8 @@ class ReplicaManagerTest {
val replicaManager = setUpReplicaManagerWithMockedAddPartitionsToTxnManager(addPartitionsToTxnManager, List(tp0)) val replicaManager = setUpReplicaManagerWithMockedAddPartitionsToTxnManager(addPartitionsToTxnManager, List(tp0))
try { try {
replicaManager.becomeLeaderOrFollower(1, val leaderDelta = topicsCreateDelta(localId, isStartIdLeader = true, partitions = List(0, 1), List.empty, topic, topicIds(topic))
makeLeaderAndIsrRequest(topicIds(tp0.topic), tp0, Seq(0, 1), new LeaderAndIsr(1, List(0, 1).map(Int.box).asJava)), replicaManager.applyDelta(leaderDelta, imageFromTopics(leaderDelta.apply()))
(_, _) => ())
val transactionalRecords = MemoryRecords.withTransactionalRecords(Compression.NONE, producerId, producerEpoch, sequence, val transactionalRecords = MemoryRecords.withTransactionalRecords(Compression.NONE, producerId, producerEpoch, sequence,
new SimpleRecord("message".getBytes)) new SimpleRecord("message".getBytes))