root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Remove staticmethod tag to be able to use logger of instance (#9086) 

A system test failed with the following error: global name 'self' is not defined

The reason was that `self` was accessed to log a message in a static method. This commit makes the method an instance method.

Reviewer: Matthias J. Sax <matthias@confluent.io>
This commit is contained in:
Bruno Cadonna 2020-07-27 18:38:14 +02:00 committed by GitHub
parent 11f75691b8
commit ac3a51d013
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/kafkatest/tests/streams/base_streams_test.py
View File

@ -95,8 +95,7 @@ class BaseStreamsTest(KafkaTest):
timeout_sec=60, timeout_sec=60,
err_msg="Did expect to read '%s' from %s" % (message, processor.node.account)) err_msg="Did expect to read '%s' from %s" % (message, processor.node.account))
@staticmethod def verify_from_file(self, processor, message, file):
def verify_from_file(processor, message, file):
result = processor.node.account.ssh_output("grep -E '%s' %s | wc -l" % (message, file), allow_fail=False) result = processor.node.account.ssh_output("grep -E '%s' %s | wc -l" % (message, file), allow_fail=False)
try: try:
return int(result) return int(result)